You may need to run go get -u golang.org/dl/gotip && gotip download to make sure you're on the version of the wrapper that sets it.

right... forgot to mention I did gotip download

Did you run go get -u, with the -u flag?

Never downloaded gotip on this machine before so didn't think it mattered. But just to be sure I did ran it with -u and no change.

gotip env does show GOROOT to be C:\Go instead of %USERPROFILE%\sdk\gotip

Are you setting GOROOT directly anywhere on your system?

Nope, only set GOPATH nothing more.

OHHH the windows installer set GOROOT under system variables and I didn't checked there.

Still one would assume gotip to set GOROOT no?

In general, Go installations nowadays should not set up GOROOT. It is inferred from the location of the go binary you are running.

If you do specify a GOROOT via an env var, it's always used directly. So if your system sets GOROOT, you'll also have to set it up when calling gotip or any other binary Go installation.

gotip doesn't set GOROOT because it isn't necessary. And presumably, also because users can set their own GOROOT, overriding the default.

So in this case, I'd say this is not a bug; you should either not have GOROOT set up, or you should set it up when calling gotip. But I'll leave the issue open for now, in case it's decided that there's something to fix in programs like gotip.

If it's decided that there's nothing to do here I'm fine with that.

Should I file a new report for the official windows installer setting GOROOT?

Should I file a new report for the official windows installer setting GOROOT?

I'd do that; see https://golang.org/doc/go1.10#goroot. Setting it is usually harmless, but can be confusing when one uses multiple Go versions, like you're trying to do.

I've also sent https://go-review.googlesource.com/c/go/+/161758, as I still found pieces of the official documentation which recommeded setting up GOROOT.

Looks like this is tracked in the new issue. Closing.

@agnivade not exactly, they are related yes but quite different.

This issue is about whether x/dl/version should ignore a set GOROOT as the point of x/dl/version is to use a specific Go version.

x/dl/version just installs a go distribution. And the Go distribution will always use a GOROOT env var if it is specifically set. I don't think there is any bug here with x/dl/version.