Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: Github throttle guard and test coverage increase #30122

Closed
Skarlso opened this issue Feb 7, 2019 · 1 comment
Closed

x/build/maintner: Github throttle guard and test coverage increase #30122

Skarlso opened this issue Feb 7, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Feb 7, 2019

As part of the work for #29396 I increased the coverage considerably around github.go. I also introduced a guard around Github throttling and / or failing for some reason to respond.

Although it's this might not fix the related issue, I failed to find the correct solution on that regard. It's probably some race condition that I'm not seeing.

However, the related PR is still solid in regards to test coverage increase which I'm extracting into this issue so the other one may be researched by someone more acquainted with the related code.
@gopherbot gopherbot added this to the Unreleased milestone Feb 7, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 7, 2019
@Skarlso Skarlso mentioned this issue Feb 7, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/157437 mentions this issue: maintner: make GitHub issue events consistent with API values

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Mar 1, 2019
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@codebien
maintner: increase test coverage for github.go and maintner.go
37cbcbc 
This change set increases the coverage around Event parsing and handling in github.go.

Fixes golang/go#30122

Change-Id: Id0349be892ba14820bdbe2132ed4acd092902f84
GitHub-Last-Rev: cc57f3d
GitHub-Pull-Request: golang#16
Reviewed-on: https://go-review.googlesource.com/c/build/+/157437
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

maintner: increase test coverage for github.go and maintner.go Skarlso/build
3 participants
@Skarlso @bcmills @gopherbot