Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: don't suggest test functions in non-test files #30100

Closed
stamblerre opened this issue Feb 6, 2019 · 2 comments
Closed

x/tools/internal/lsp: don't suggest test functions in non-test files #30100

stamblerre opened this issue Feb 6, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

Example:

b.go

package b

func a() {}

b_test.go

package b

import "testing"

func TestA(t *testing.T) {}

Completion in b.go will give "TestA" as a result, when it should not.
@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2019
@stamblerre stamblerre self-assigned this Feb 6, 2019
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 6, 2019
@stamblerre stamblerre added gopls Issues related to the Go language server, gopls. and removed gopls Issues related to the Go language server, gopls. labels Mar 12, 2019
@muirdm muirdm mentioned this issue May 30, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/179557 mentions this issue: internal/lsp: don't complete test objects in non-test files

@muirdm muirdm mentioned this issue Jun 9, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/183628 mentions this issue: internal/lsp: support a file belonging to multiple packages

@golang golang locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

internal/lsp: don't complete test objects in non-test files muirdm/tools
3 participants
@andybons @stamblerre @gopherbot