New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/release: verify that releases with & without all.bash tests produce same results #30028
Comments
Running two builds now. |
Yeah, 6MB bigger if you run tests...
@ianlancetaylor, I assume it's fine if we prune all those before tarring things up? They'll just be built lazily when needed. And I assume |
Yes, those directories can be removed before tarring up the release. Of course we shouldn't be creating them in the first place. |
You mean tests should clean up after themselves when those get created implicitly? |
Change https://golang.org/cl/160660 mentions this issue: |
I recall hearing speculation that cmd/release produces different release tarballs/zips when we run it in all.bash-vs-make.bash modes.
Check that before release. (And fix if necessary, such that the releases are the smaller of the two: probably make.bash, if all.bash leaves misc buildmode *.a/artifacts around)
/cc @bcmills @ianlancetaylor @dmitshur @katiehockman @andybons
The text was updated successfully, but these errors were encountered: