Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/smtp: add missing error check in test #30018

Closed
wants to merge 1 commit into from
Closed

net/smtp: add missing error check in test #30018

wants to merge 1 commit into from

Conversation

leonklingele
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 30, 2019
@gopherbot
Copy link

This PR (HEAD: c26c315) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/160442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1

Thank you Leon! I'll run the trybots and also tag this for Go1.13.

R=Go1.13

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=25382acb

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Miasoedov:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 7 times, most recently from 4a7ed1f to 0f992b9 Compare November 5, 2019 02:56
@mvdan mvdan force-pushed the net-smtp-add-missing-error-check branch from c26c315 to 67f97d1 Compare November 5, 2019 16:18
@gopherbot
Copy link

This PR (HEAD: 67f97d1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/160442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 1: Code-Review+2

This got missed because there's a typo in the wait-release label, apologies. Will rebase and merge.

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 3: Patch Set 2 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Leon Klingele:

Patch Set 3:

It looks like this change has been implemented in master already (although with a slightly misleading error message — it's a ReadLine error, not an error from PrintfLine):

go/src/net/smtp/smtp_test.go

Lines 658 to 665 in 414c1d4

msg, err := tc.ReadLine()
if msg == "EHLO localhost" {
tc.PrintfLine("250 mx.google.com at your service")
}
if err != nil {
errCh <- fmt.Errorf("PrintfLine: %v", err)
return
}

Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 11, 2019
@leonklingele @bradfitz
net/smtp: add missing error check in test
ee706cf 
Change-Id: Ifcbd9d2961073a18a250f052180248d9bf223e97
GitHub-Last-Rev: 67f97d1
GitHub-Pull-Request: #30018
Reviewed-on: https://go-review.googlesource.com/c/go/+/160442
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leonklingele @gopherbot @googlebot