internal/x/text/unicode/bidi: ignore unused return values in test #30015
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 7ffd936) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/160439 to see it. Tip: You can toggle comments from me using the |
leonklingele
force-pushed
the
internal-x-text-unicode-bidi-ignore-unused-return-values
branch
from
7ffd936
to
bb0ebc9
Compare
|
This PR (HEAD: bb0ebc9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/160439 to see it. Tip: You can toggle comments from me using the |
leonklingele
changed the title
|
Message from Emmanuel Odeke: Patch Set 3: Code-Review-1 Thank you Leon for sending this CL! Unfortunately the change you've made is on an auto-generated file. // Code generated by running "go run gen.go -core" in golang.org/x/text. DO NOT EDIT. Please don’t reply on this GitHub thread. Visit golang.org/cl/160439. |
|
Message from Leon Klingele: Patch Set 3: Is that test file even used for anything? Grepping my whole GOPATH for "StringAttributes" (a type used in example_test.go) doesn't reveal where exactly the type is defined. (Also see https://go-review.googlesource.com/c/go/+/160445/1/src/internal/x/text/unicode/bidi/example_test.go#87 for why the file likely will not compile). Please don’t reply on this GitHub thread. Visit golang.org/cl/160439. |
|
File should be removed altogether. #30671 |
No description provided.