Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: -Waddress-of-packed-member warnings poping up with gcc9 in cgo-gcc-prolog [1.10 backport] #29966

Closed
gopherbot opened this issue Jan 28, 2019 · 2 comments
Closed

cmd/cgo: -Waddress-of-packed-member warnings poping up with gcc9 in cgo-gcc-prolog [1.10 backport] #29966

gopherbot opened this issue Jan 28, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.9

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #29962 to be considered for backport to the next 1.10 minor release.

@gopherbot please open backport issues
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 28, 2019
@gopherbot gopherbot mentioned this issue Jan 28, 2019
Closed
@gopherbot gopherbot added this to the Go1.10.9 milestone Jan 28, 2019
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jan 30, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 30, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/160450 mentions this issue: [release-branch.go1.10] cmd/cgo: disable GCC 9 warnings triggered by cgo code

@gopherbot
Copy link
Contributor Author

Closed by merging 396ff0d to release-branch.go1.10.

gopherbot pushed a commit that referenced this issue Feb 1, 2019
@ianlancetaylor @bradfitz
[release-branch.go1.10] cmd/cgo: disable GCC 9 warnings triggered by …
396ff0d 
…cgo code

GCC 9 has started emitting warnings when taking the address of a field
in a packed struct may cause a misaligned pointer. We use packed
structs in cgo to ensure that our field layout matches the C
compiler's layout. Our pointers are always aligned, so disable the warning

Updates #29962
Fixes #29966

Change-Id: I7e290a7cf694a2c2958529e340ebed9fcd62089c
Reviewed-on: https://go-review.googlesource.com/c/159859
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit f2a416b)
Reviewed-on: https://go-review.googlesource.com/c/160450
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.9
Development

No branches or pull requests
2 participants
@bcmills @gopherbot