Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text: tag a more recent commit #29937

Closed
hyangah opened this issue Jan 25, 2019 · 3 comments
Closed

x/text: tag a more recent commit #29937

hyangah opened this issue Jan 25, 2019 · 3 comments
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 25, 2019 •
edited by dmitshur

In module mode, golang.org/x/text picks up more than a year old commit
because its tag, though set before module support, follows semver format.
Providing a tag with a more recent commit will help x/text users transitioning to module mode.

$ GOPATH=$(mktemp -d) GO111MODULE=on tipgo list -versions -json -m golang.org/x/text
go: finding golang.org/x/text v0.3.0
{
	"Path": "golang.org/x/text",
	"Version": "v0.3.0",
	"Versions": [
		"v0.1.0",
		"v0.2.0",
		"v0.3.0"
	],
	"Time": "2017-12-14T13:08:43Z"
}
@gopherbot gopherbot added this to the Unreleased milestone Jan 25, 2019
@bcmills
Copy link
Contributor

bcmills commented Jan 25, 2019

CC @mpvl

@chetaldrich chetaldrich mentioned this issue Feb 26, 2019
Closed
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 1, 2019
@AlekSi
Copy link
Contributor

AlekSi commented Jul 14, 2020

v0.3.3 was tagged recently: https://pkg.go.dev/golang.org/x/text@v0.3.3?tab=versions. I think this issue can be closed.

@mvdan
Copy link
Member

mvdan commented Jul 14, 2020

Indeed, @katiehockman tagged a version in June. I'm closing this.

@mvdan mvdan closed this as completed Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@AlekSi @mvdan @hyangah @bcmills @gopherbot