Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: Go 1.11.5 amd64 tarball includes /gocache and /tmp #29906

Closed
tendervittles opened this issue Jan 23, 2019 · 10 comments
Closed

x/build/cmd/release: Go 1.11.5 amd64 tarball includes /gocache and /tmp #29906

tendervittles opened this issue Jan 23, 2019 · 10 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.11.6

Comments

@tendervittles
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.11.5 linux/amd64

Does this issue reproduce with the latest release?

Install the LInux amd64 tarball.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

$ mkdir x
$ tar -C x -zxf ~/Downloads/go1.11.5.linux-amd64.tar.gz
$ cd x
$ ls
go  gocache  tmp
$ cd gocache
$ du -skh
63M	.

What did you expect to see?

A single go directory.

What did you see instead?

An empty tmp and 63M of gocache.
@bradfitz bradfitz changed the title Go 1.11.5 amd64 tarball includes /gocache and /tmp x/build/cmd/release: Go 1.11.5 amd64 tarball includes /gocache and /tmp Jan 23, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jan 23, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 23, 2019
@bradfitz
Copy link
Contributor

/cc @dmitshur @julieqiu @katiehockman

@bradfitz bradfitz modified the milestones: Unreleased, Go1.12 Jan 23, 2019
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jan 23, 2019
@julieqiu
Copy link
Member

Thanks for letting us know. We're currently looking into this.

@dmitshur dmitshur added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Jan 23, 2019
@bradfitz
Copy link
Contributor

I'm sending a fix.

@gopherbot
Copy link

Change https://golang.org/cl/159257 mentions this issue: cmd/release: remove the tmp and gocache dirs, validate it doesn't happen again

@jayconrod jayconrod mentioned this issue Jan 23, 2019
Merged
@julieqiu
Copy link
Member

julieqiu commented Jan 24, 2019 •
edited by FiloSottile

We have confirmed that the extraneous directories gocache and tmp are harmless and safe to remove.

Only go1.11.5.linux-amd64.tar.gz and go1.10.8.linux-amd64.tar.gz are affected.

We will not be updating the tarballs for this release. The reason is because these directories do not affect functionality, and we do not want to risk the availability of the security release, nor we want to change the contents of already published archives.

If you have already extracted the archives, you can optionally remove the unnecessary directories.

The following commands can be used to extract only the necessary go directory from the archives:

tar -C /usr/local -xzf go1.11.5.linux-amd64.tar.gz go
tar -C /usr/local -xzf go1.10.8.linux-amd64.tar.gz go

These commands will create a Go tree in /usr/local/go.

While investigating we also noticed these directories missing from the tarball due to a change in how tests are run during the release process:

  • go/pkg/linux_amd64_dynlink
  • go/pkg/linux_amd64_shared
  • go/pkg/linux_amd64_testcshared_shared

This should not cause any disruption, but it is something we will look into for future releases.

@julieqiu julieqiu modified the milestones: Go1.12, Go1.11.6 Jan 24, 2019
@julieqiu julieqiu removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label Jan 24, 2019
@bradfitz bradfitz reopened this Jan 24, 2019
@bradfitz
Copy link
Contributor

That CL was submitted too early.

@gopherbot
Copy link

Change https://golang.org/cl/159320 mentions this issue: cmd/buildlet: recreate accidentally deleted dirs lazily

@wingyplus wingyplus mentioned this issue Jan 24, 2019
Closed
5 tasks
@fxcoudert
Copy link

Only go1.11.5.linux-amd64.tar.gz and go1.10.8.linux-amd64.tar.gz are affected.

I do not believe that to be true. go1.11.5.src.tar.gz from https://dl.google.com/go/go1.11.5.src.tar.gz also has gocache and tmp directories.

ricardoseriani added a commit to ricardoseriani/settler that referenced this issue Jan 24, 2019
@ricardoseriani
Ensure that only extract the go folder from zip
defe3ca 
In release 1.11.5 the golang.tar.gz for some architectures contains others folders than go (see: golang/go#29906)

Signed-off-by: Ricardo Seriani <ricardo.seriani@gmail.com>
ricardoseriani added a commit to ricardoseriani/settler that referenced this issue Jan 24, 2019
@ricardoseriani
Ensure that only extract the go folder from golang.tar.gz
906361d 
In release 1.11.5 the golang.tar.gz for some architectures contains others folders than go (see: golang/go#29906)

Signed-off-by: Ricardo Seriani <ricardo.seriani@gmail.com>
svpernova09 pushed a commit to laravel/settler that referenced this issue Jan 24, 2019
@ricardoseriani @svpernova09
Update golang version to 1.11.5 (#188)
48a1de7 
* Update golang version to 1.11.5

Signed-off-by: Ricardo Seriani <ricardo.seriani@gmail.com>

* Ensure that only extract the go folder from golang.tar.gz

In release 1.11.5 the golang.tar.gz for some architectures contains others folders than go (see: golang/go#29906)

Signed-off-by: Ricardo Seriani <ricardo.seriani@gmail.com>
@julieqiu
Copy link
Member

Yes, the gocache and tmp directories are in go1.11.5.src.tar.gz, but unlike the ones in go1.11.5.linux-amd64.tar.gz and go1.10.8.linux-amd64.tar.gz they are empty.

We will fix this for the next release.

maruel added a commit to periph/bootstrap that referenced this issue Jan 24, 2019
@maruel
setup.sh: workaround bad Go 1.11.5 tarball
c7e48ff 
The go1.11.5 tarballs include extraneous 'gocache' and 'tmp'
directories. Protect against that.
golang/go#29906
@dmitshur dmitshur mentioned this issue Feb 12, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/161967 mentions this issue: cmd/release: clean gocache and tmp in source mode too

gopherbot pushed a commit to golang/build that referenced this issue Feb 12, 2019
@bradfitz
cmd/release: clean gocache and tmp in source mode too
e6f0055 
I missed this in CL 159257 when fixing golang/go#29906 the first time.

Fixes golang/go#30181 (round two)

Change-Id: Iae90b5b19803e1ef7297b57bae7644e16c44efdc
Reviewed-on: https://go-review.googlesource.com/c/161967
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This was referenced Feb 15, 2019
Closed
Merged
@golang golang locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.11.6
Development

No branches or pull requests
6 participants
@bradfitz @dmitshur @fxcoudert @tendervittles @julieqiu @gopherbot