x/net/webdav: no trailing slash on href to a directory #29858

mickael-kerjean · 2019-01-22T01:14:06Z

What version of Go are you using (`go version`)?

go version go1.11 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

go env Output

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/mickael/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/mickael/Documents/projects/go/"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.11/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.11/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/7w/08pnvwm554xc18_b012cbgs00000gn/T/go-build184274398=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I've created a webdav server based on https://godoc.org/golang.org/x/net/webdav then started querying it:

echo '<?xml version="1.0"?><a:propfind xmlns:a="DAV:"><a:prop><a:resourcetype/></a:prop></a:propfind>' | curl -X PROPFIND http://127.0.0.1:8334/s/SrRunIQ/ -H "Depth: 1" --upload-file - | xmllint --format -

What did you expect to see?

Like other webdav servers I made some test with, I expected the href attribute to end with a "/" for directories

What did you see instead?

The href attribute never end with a "/"

<?xml version="1.0" encoding="UTF-8"?>
<D:multistatus xmlns:D="DAV:">
   .....
  <D:response>
    <D:href>/s/SrRunIQ/paper</D:href> <- is a folder but doesn't end with a "/"
    <D:propstat>
      <D:prop>
        <D:resourcetype>
          <D:collection xmlns:D="DAV:"/>
        </D:resourcetype>
      </D:prop>
      <D:status>HTTP/1.1 200 OK</D:status>
    </D:propstat>
  </D:response>
  ....
</D:multistatus>

I made a quick fix as this piece of code is a big deal in the context of where I'm using the webdav server for.

The text was updated successfully, but these errors were encountered:

bcmills · 2019-01-22T14:14:27Z

CC @bradfitz @nigeltao

bradfitz · 2019-01-22T15:03:23Z

Does the spec say anything about this?

mickael-kerjean · 2019-01-23T02:34:27Z

In RFC 4918:

The rules in this section apply ... to resource URLs in the 'href' ...... Identifiers for collections SHOULD end in a '/' character.

mickael-kerjean · 2019-01-23T02:40:02Z

other webdav server - install

Apache webdav:

docker run -ti --name webdav -p 8888:80 ubuntu:latest bash
apt update
apt install curl apache2 vim libxml2-utils
mkdir /var/www/webdav
chown -R www-data:www-data /var/www/
a2enmod dav
a2enmod dav_fs
vi /etc/apache2/sites-available/000-default.conf
# https://www.digitalocean.com/community/tutorials/how-to-configure-webdav-access-with-apache-on-ubuntu-14-04
service apache2 restart

touch /var/www/webdav/test.html
mkdir /var/www/webdav/test
echo '<?xml version="1.0"?><a:propfind xmlns:a="DAV:"><a:prop><a:resourcetype/></a:prop></a:propfind>' | curl -X PROPFIND http://127.0.0.1/webdav/ --upload-file - -H "Depth: 1" | xmllint --format -

Sabre dav via Nextcloud:

Creating an account on their demo

other webdav server - test

via curl:

echo '<?xml version="1.0"?><a:propfind xmlns:a="DAV:"><a:prop><a:resourcetype/></a:prop></a:propfind>' | curl -X PROPFIND http://127.0.0.1/webdav/ --upload-file - -H "Depth: 1"

observation:

On both servers, the href attribute in the xml end with a "/" for collections. Example response using the Apache webdav with 2 things inside the webdav folder: 1 directory called "test" and a file called test.html

<?xml version="1.0" encoding="utf-8"?>
<D:multistatus xmlns:D="DAV:" xmlns:ns0="DAV:">
  <D:response xmlns:lp1="DAV:">
    <D:href>/webdav/</D:href>
    <D:propstat>
      <D:prop>
        <lp1:resourcetype>
          <D:collection/>
        </lp1:resourcetype>
      </D:prop>
      <D:status>HTTP/1.1 200 OK</D:status>
    </D:propstat>
  </D:response>
  <D:response xmlns:lp1="DAV:">
    <D:href>/webdav/test.html</D:href>
    <D:propstat>
      <D:prop>
        <lp1:resourcetype/>
      </D:prop>
      <D:status>HTTP/1.1 200 OK</D:status>
    </D:propstat>
  </D:response>
  <D:response xmlns:lp1="DAV:">
    <D:href>/webdav/test/</D:href>
    <D:propstat>
      <D:prop>
        <lp1:resourcetype>
          <D:collection/>
        </lp1:resourcetype>
      </D:prop>
      <D:status>HTTP/1.1 200 OK</D:status>
    </D:propstat>
  </D:response>
</D:multistatus>

the href field has a "/" at the end of the HREF for directories

nigeltao · 2019-01-24T01:35:22Z

CC @rsto

rsto · 2019-01-24T08:14:46Z

The patch LGTM.

Just curious: is the trailing / for collections expected by a particular DAV client or library?

mickael-kerjean · 2019-01-24T09:59:45Z

No idea, personally, I wanted to use this as an optimisation in this project to reduce the network round trip as my data isn't store locally but on some remote backends: S3, FTP, SFTP, ...

mickael-kerjean · 2019-01-24T10:12:58Z

Also, let me know if I'm wrong but the current implementation of the webdav server seems to assume that opening a file and performing a stat is a cheap operation. In my scenario trying to make a webdav server of an S3 bucket, such an assumption is not true and is large of a consequence when the webdav server is mounted on the OS. To fix this, I made some additional changes in the webdav implementation to avoid unnecessary file opening, stats and close in the request lifecycle. Any chance that this problem of unnecessary file opening could be fix in the meantime?

nigeltao · 2019-01-25T00:36:24Z

I only skimmed them briefly, but I think both changes are broadly acceptable (as two separate changes).

The contribution guidelines are at
https://golang.org/doc/contribute.html

If you haven't submitted a Go patch before, note that we will need https://golang.org/doc/contribute.html#cla

If you're familiar with GitHub's flow, you might want to follow https://golang.org/doc/contribute.html#sending_a_change_github which is a relatively new process.

gopherbot · 2019-02-27T15:51:18Z

Change https://golang.org/cl/163863 mentions this issue: webdav: add trailing slash on directories

This is a test to fix golang/go#29858 When passed the "/" directory, it adds an additional "/" which upsets some clients (duplicacy for instance).

Fixes golang/go#29858 Change-Id: I7bd8357a7def7daab1fd6357a888ff4e676a1bee GitHub-Last-Rev: a6dc776fa3aad595643943dcff88efcf152d6be1 GitHub-Pull-Request: golang/net#32 Reviewed-on: https://go-review.googlesource.com/c/163863 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

bcmills changed the title ~~net/webdav~~ x/net/webdav: no trailing slash on href to a directory Jan 22, 2019

gopherbot added this to the Unreleased milestone Jan 22, 2019

bradfitz added help wanted NeedsInvestigation labels Jan 22, 2019

mickael-kerjean closed this as completed Jan 23, 2019

mickael-kerjean reopened this Jan 23, 2019

mickael-kerjean mentioned this issue Feb 27, 2019

webdav: add trailing slash on directories golang/net#32

Closed

gopherbot closed this as completed in golang/net@c95aed5 Feb 27, 2019

ncw added a commit to rclone/rclone that referenced this issue Jun 6, 2019

Test a fix for #3002 - DO NOT MERGE

af7e065

This is a test to fix golang/go#29858 When passed the "/" directory, it adds an additional "/" which upsets some clients (duplicacy for instance).

ncw mentioned this issue Jun 6, 2019

standardize rclone webdav implementation valid for duplicacy rclone/rclone#3002

Closed

golang locked and limited conversation to collaborators Feb 27, 2020

gopherbot added the FrozenDueToAge label Feb 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/net/webdav: no trailing slash on href to a directory #29858

x/net/webdav: no trailing slash on href to a directory #29858

mickael-kerjean commented Jan 22, 2019 •

edited

Loading

bcmills commented Jan 22, 2019

bradfitz commented Jan 22, 2019

mickael-kerjean commented Jan 23, 2019

mickael-kerjean commented Jan 23, 2019 •

edited

Loading

nigeltao commented Jan 24, 2019

rsto commented Jan 24, 2019

mickael-kerjean commented Jan 24, 2019

mickael-kerjean commented Jan 24, 2019 •

edited

Loading

nigeltao commented Jan 25, 2019

gopherbot commented Feb 27, 2019

x/net/webdav: no trailing slash on href to a directory #29858

x/net/webdav: no trailing slash on href to a directory #29858

Comments

mickael-kerjean commented Jan 22, 2019 • edited Loading

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

bcmills commented Jan 22, 2019

bradfitz commented Jan 22, 2019

mickael-kerjean commented Jan 23, 2019

mickael-kerjean commented Jan 23, 2019 • edited Loading

other webdav server - install

other webdav server - test

nigeltao commented Jan 24, 2019

rsto commented Jan 24, 2019

mickael-kerjean commented Jan 24, 2019

mickael-kerjean commented Jan 24, 2019 • edited Loading

nigeltao commented Jan 25, 2019

gopherbot commented Feb 27, 2019

mickael-kerjean commented Jan 22, 2019 •

edited

Loading

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

mickael-kerjean commented Jan 23, 2019 •

edited

Loading

mickael-kerjean commented Jan 24, 2019 •

edited

Loading