Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/constant: add accessors for float and int constants #29820

Closed
stamblerre opened this issue Jan 18, 2019 · 3 comments
Closed

go/constant: add accessors for float and int constants #29820

stamblerre opened this issue Jan 18, 2019 · 3 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@stamblerre
Copy link
Contributor

Constants with the kind constant.Float and constant.Int are represented by the types *big.Float, *big.Rat, and *big.Int, but users of the go/constant package aren't able to access these values. It would make things a lot simpler for users if we could add an accessor to these values in the go/constant package.

Justification: https://github.com/golang/tools/blob/a53bc13a6341e9847bbcf8c0a0691e60e18a87c0/go/internal/gcimporter/bexport.go#L624.
@stamblerre stamblerre self-assigned this Jan 18, 2019
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest labels Jan 29, 2019
@bcmills
Copy link
Contributor

bcmills commented Jan 29, 2019

Should this be milestoned for 1.13, or Unplanned?

@stamblerre
Copy link
Contributor Author

I think I could aim to do it for 1.13.

@gopherbot
Copy link

Change https://golang.org/cl/164538 mentions this issue: go/constant: add big.Int, big.Float, and big.Rat accessors

@golang golang locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcmills @stamblerre @gopherbot