Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: tests are flaky on Windows #29819

Open
heschi opened this issue Jan 18, 2019 · 2 comments
Open

x/tools/go/packages: tests are flaky on Windows #29819

heschi opened this issue Jan 18, 2019 · 2 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented Jan 18, 2019

https://build.golang.org/log/60aa789811bdedb1697255f1dee30adb917d3f0c
https://build.golang.org/log/ede332848726e7af41109fe3ebc7e813e58f7ab8
https://storage.googleapis.com/go-build-log/dc889025/windows-amd64-2016_fed5c8f5.log

example:

--- FAIL: TestLoadTypes (0.50s)
    --- FAIL: TestLoadTypes/Modules (0.34s)
        packages_test.go:523: wrong import graph: got <<>>, want <<* golang.org/fake/a
              golang.org/fake/b
              golang.org/fake/c
              golang.org/fake/a -> golang.org/fake/b
              golang.org/fake/a -> golang.org/fake/c
            >>
        packages_test.go:541: missing package: golang.org/fake/a
        packages_test.go:541: missing package: golang.org/fake/b
        packages_test.go:541: missing package: golang.org/fake/c
FAIL
FAIL	golang.org/x/tools/go/packages	34.826s
@gopherbot gopherbot added this to the Unreleased milestone Jan 18, 2019
@matloob
Copy link
Contributor

matloob commented Jan 18, 2019

yeah sigh :(

@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 18, 2019
@dmitshur
Copy link
Contributor

dmitshur commented Mar 6, 2019

I'm not sure if this is the same issue or another, but I'm also seeing the following test failures on Windows trybots (all other trybots pass):

--- FAIL: TestLoadSyntaxOK (0.65s)
    --- FAIL: TestLoadSyntaxOK/Modules (0.24s)
        packages_test.go:606: wrong import graph: got <<>>, want <<* golang.org/fake/a
              golang.org/fake/b
            * golang.org/fake/c
              golang.org/fake/d
              golang.org/fake/e
              golang.org/fake/f
              golang.org/fake/a -> golang.org/fake/b
              golang.org/fake/b -> golang.org/fake/c
              golang.org/fake/c -> golang.org/fake/d
              golang.org/fake/d -> golang.org/fake/e
              golang.org/fake/e -> golang.org/fake/f
            >>
        packages_test.go:631: missing package: golang.org/fake/a
        packages_test.go:631: missing package: golang.org/fake/b
        packages_test.go:631: missing package: golang.org/fake/c
        packages_test.go:631: missing package: golang.org/fake/d
        packages_test.go:631: missing package: golang.org/fake/e
        packages_test.go:631: missing package: golang.org/fake/f
        packages_test.go:659: a.A: got nil
FAIL
FAIL	golang.org/x/tools/go/packages	37.982s

And:

panic: runtime error: index out of range [recovered]
	panic: runtime error: index out of range

goroutine 439 [running]:
testing.tRunner.func1(0x12810000)
	C:/workdir/go/src/testing/testing.go:830 +0x30e
panic(0x69a260, 0x90df70)
	C:/workdir/go/src/runtime/panic.go:532 +0x165
golang.org/x/tools/go/packages_test.testParseFileModifyAST(0x12810000, 0x740990, 0x92489c)
	C:/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:810 +0x3d7
golang.org/x/tools/go/packages/packagestest.TestAll.func1(0x12810000)
	C:/workdir/gopath/src/golang.org/x/tools/go/packages/packagestest/export.go:99 +0x51
testing.tRunner(0x12810000, 0x12776140)
	C:/workdir/go/src/testing/testing.go:865 +0x97
created by testing.(*T).Run
	C:/workdir/go/src/testing/testing.go:916 +0x2b2
FAIL	golang.org/x/tools/go/packages	26.424s

From CL 160837.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

5 participants