Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: diagnostics are not updated if fixed in another file #29817

Closed
stamblerre opened this issue Jan 18, 2019 · 1 comment
Closed

x/tools/internal/lsp: diagnostics are not updated if fixed in another file #29817

stamblerre opened this issue Jan 18, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

Example:

a.go

func a() {
   b(1)
}

b.go

func b(x string) { ... }

If a change is made to change the signature of function b to func b(x int), the diagnostic in a.go would not be updated until a.go is changed. This change should be propagated correctly to the relevant files.
@bcmills bcmills changed the title internal/lsp: diagnostics are not updated if fixed in another file x/tools/internal/lsp: diagnostics are not updated if fixed in another file Jan 29, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jan 29, 2019
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 29, 2019
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jan 29, 2019
@stamblerre stamblerre added gopls Issues related to the Go language server, gopls. and removed gopls Issues related to the Go language server, gopls. labels Mar 12, 2019
@gopherbot
Copy link

Change https://golang.org/cl/174977 mentions this issue: internal/lsp: propagate diagnostics for reverse dependencies

@golang golang locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @stamblerre @gopherbot