Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp: add tests for constant completion #29816

Closed
stamblerre opened this issue Jan 18, 2019 · 6 comments
Closed

x/tools/internal/lsp: add tests for constant completion #29816

stamblerre opened this issue Jan 18, 2019 · 6 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@stamblerre
Copy link
Contributor

There are currently no tests for completion of constants.

@stamblerre stamblerre added the Suggested Issues that may be good for new contributors looking for work to do. label Jan 18, 2019
@Avni-Sharma
Copy link

Hi Rebecca, can you guide me as to where internal/lsp resides

@agnivade
Copy link
Contributor

@stamblerre stamblerre changed the title internal/lsp: add tests for constant completion x/tools/internal/lsp: add tests for constant completion Jan 26, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jan 26, 2019
@stamblerre
Copy link
Contributor Author

Thanks @agnivade. Changed the title - sorry, I forgot to note that it's in x/tools.

@stamblerre stamblerre added gopls Issues related to the Go language server, gopls. and removed gopls Issues related to the Go language server, gopls. labels Mar 12, 2019
@johansja
Copy link

johansja commented May 7, 2019

Is this still relevant? Where should I look at to pick up on this?

@stamblerre
Copy link
Contributor Author

Yes it is! Basically we need tests for completion when the item being completed is a constant. For an example of how the test format looks, you can check out https://github.com/golang/tools/blob/master/internal/lsp/testdata/bar/bar.go.in or any of the files in the testdata directory. Basically, items that should appear in the results get marked as "item" and then to trigger a completion test, we add the "complete" marker. The testing framework is quite complex, so feel free to ask me any questions on here.

@gopherbot
Copy link

Change https://golang.org/cl/177357 mentions this issue: internal/lsp: remove constant value from label and add tests

@golang golang locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

5 participants