Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: build broken on Windows #29796

Closed
bcmills opened this issue Jan 17, 2019 · 1 comment
Closed

x/build/cmd/coordinator: build broken on Windows #29796

bcmills opened this issue Jan 17, 2019 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 17, 2019

Probably we should just notch it out via +build constraints.

log: https://storage.googleapis.com/go-build-log/6e9f664b/windows-386-2008_a4bdccc5.log

# golang.org/x/build/cmd/coordinator [golang.org/x/build/cmd/coordinator.test]
cmd\coordinator\remote.go:592:12: undefined: pty.Start
cmd\coordinator\remote.go:612:17: not enough arguments in call to syscall.Syscall
cmd\coordinator\remote.go:612:18: undefined: syscall.SYS_IOCTL
cmd\coordinator\remote.go:612:53: undefined: syscall.TIOCSWINSZ
FAIL	golang.org/x/build/cmd/coordinator [build failed]

CC @dmitshur @bradfitz
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 17, 2019
@bradfitz
Copy link
Contributor

Your git parent was old. Same as other bug.

@golang golang locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradfitz @bcmills @gopherbot