Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: TestCommitMessage fails in TryBots #29794

Closed
bcmills opened this issue Jan 17, 2019 · 2 comments
Closed

x/build/cmd/gerritbot: TestCommitMessage fails in TryBots #29794

bcmills opened this issue Jan 17, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 17, 2019

The TryBots only recently starting working for x/build at all (see #14594), so it's no surprise that we need to do some fixing.

Log: https://storage.googleapis.com/go-build-log/6e9f664b/linux-amd64-race_eacc0b96.log

--- FAIL: TestCommitMessage (0.00s)
    --- FAIL: TestCommitMessage/simple (0.00s)
        gerritbot_test.go:110: got unexpected error from commitMessage: could not execute command [git stripspace]: exec: "git": executable file not found in $PATH
    --- FAIL: TestCommitMessage/change_with_Change-Id (0.00s)
        gerritbot_test.go:110: got unexpected error from commitMessage: could not execute command [git stripspace]: exec: "git": executable file not found in $PATH
    --- FAIL: TestCommitMessage/Change-Id_in_body_text (0.00s)
        gerritbot_test.go:110: got unexpected error from commitMessage: could not execute command [git stripspace]: exec: "git": executable file not found in $PATH
    --- FAIL: TestCommitMessage/Change-Id_in_body_text_with_an_existing_CL (0.00s)
        gerritbot_test.go:110: got unexpected error from commitMessage: could not execute command [git stripspace]: exec: "git": executable file not found in $PATH
FAIL
FAIL	golang.org/x/build/cmd/gerritbot	0.013s

CC @dmitshur @bradfitz
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 17, 2019
@bcmills bcmills changed the title golang.org/x/build/cmd/gerritbot: TestCommitMessage fails in TryBots x/build/cmd/gerritbot: TestCommitMessage fails in TryBots Jan 17, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jan 17, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 17, 2019
@bradfitz
Copy link
Contributor

Your git parent for that run was from November. Those bugs were fixed.

@dmitshur
Copy link
Contributor

dmitshur commented Jan 17, 2019 •
edited
Loading

I believe this was fixed in CL 157440. Is this failure from CL 152037? I think you need to rebase it on top of latest master. See here for a similar previous occurrence.

@golang golang locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @dmitshur @bcmills @gopherbot