Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: clarify the impact of the -tags flag on test/build caching #29782

Open
kortschak opened this issue Jan 17, 2019 · 3 comments
Open

cmd/go: clarify the impact of the -tags flag on test/build caching #29782

kortschak opened this issue Jan 17, 2019 · 3 comments
Assignees
@matloob
Labels
Documentation Issues describing a change to documentation. GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@kortschak
Copy link
Contributor

kortschak commented Jan 17, 2019 •
edited
Loading

What version of Go are you using (go version)?

$ go version
go version devel +4b3f04c

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="~/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="~"
GOPROXY=""
GORACE=""
GOROOT="~/go"
GOTMPDIR=""
GOTOOLDIR="~/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build224479533=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Read the documentation for build/test caching from go help test. Then

$ go test -tags noasm gonum.org/v1/gonum/mat
ok  	gonum.org/v1/gonum/mat	44.695s
$ go test -tags noasm gonum.org/v1/gonum/mat
ok  	gonum.org/v1/gonum/mat	(cached)

From this it's clear that -tags is not counted in test flags (and this is reasonably given the wording).

What did you expect to see?

No caching.

What did you see instead?

Happily, caching.

While the wording is consistent with the apparent intended meaning, it could be made clearer that build flags do not impact on caching for tests (if this is true - I could find no mention of caching in go help build or go help install or mention of which flags prevent caching (other than -a in go help cache)).
@bcmills bcmills added Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 22, 2019
@bcmills bcmills added this to the Go1.13 milestone Jan 22, 2019
@christopherdiehl
Copy link

If no one is working on this, I can take a go updating the ‘go help build’ and ‘go help install’ documentation. Please let me know if it makes sense to update any other help commands output.

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@bcmills
Copy link
Contributor

bcmills commented Sep 18, 2019

@christopherdiehl, you're welcome to take this if you like.

The paragraph about test caching and uncacheable flags is here, and probably the fix is to clarify that all build flags are cacheable.

@bcmills bcmills modified the milestones: Go1.14, Unplanned Sep 18, 2019
@ansel1
Copy link

ansel1 commented Nov 16, 2024

I've also found that changing the tags argument doesn't invalidate the cache, which seems wrong. For example:

$ go test -tags noasm gonum.org/v1/gonum/mat
ok  	gonum.org/v1/gonum/mat	44.695s
$ go test -tags yesasm gonum.org/v1/gonum/mat
ok  	gonum.org/v1/gonum/mat	(cached)

Shouldn't a different tag be treated like a change to the go test args, and therefore not be a cache hit?

@seankhliao seankhliao added the GoCommand cmd/go label Feb 22, 2025
@matloob matloob self-assigned this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matloob matloob

Labels
Documentation Issues describing a change to documentation. GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
7 participants
@ansel1 @kortschak @andybons @bcmills @christopherdiehl @seankhliao @matloob