Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes made with https://golang.org/cl/23153 can't be found in the src of Go 1.11.4 nor 1.12beta2 #29756

Closed
therecipe opened this issue Jan 15, 2019 · 3 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@therecipe
Copy link

The changes made with https://golang.org/cl/23153 (1f7a0d4) can't be found in the src pkgs of Go 1.11.4 nor 1.12beta2 downloaded from https://golang.org/dl/, they however can be found in the 1.10.7 src pkg.

@mvdan
Copy link
Member

mvdan commented Jan 15, 2019

What exactly are you trying to accomplish? That fix was merged in 2016, so all 1.11 and 1.12 tags will include the commit. If you're looking at the plain source code, it's possible that the lines have been overriden by a newer commit.

@mvdan mvdan added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 15, 2019
@ianlancetaylor
Copy link
Contributor

The change in https://golang.org/cl/23153 was removed by https://golang.org/cl/93659, because it was no longer necessary.

Closing because there is no bug here. In general questions are better directed to a forum; see https://golang.org/wiki/Questions .

@therecipe
Copy link
Author

therecipe commented Jan 15, 2019

Sorry, I though the related issue to this cl (#15639) resurfaced here therecipe/qt#767 and since the cl states No test because there shouldn't be any way to trigger this error anyhow.
I simply though these changes might be missing in error, I however haven't looked for commits that revert these changes, sorry for that.
Just found it odd that the 1.10.7 src includes the changes and newer version do not.

edit: upon re-reading the cl message, I might think I totally misread it. Sorry for the noise.

@golang golang locked and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants