Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: useless string replace operation in Cookie.String. Fixes #29135 #29728

Closed
wants to merge 1 commit into from

Conversation

bronze1man
Copy link
Contributor

net/http: useless string replace operation in Cookie.String. Fixes #29135

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 14, 2019
@gopherbot
Copy link

This PR (HEAD: 1209770) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157777 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/157777.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Volker Dobler:

Patch Set 1:

(3 comments)

Thanks for this optimization.

As this optimization removes a safety net the test should
make sure that upcoming changes do not break anything, so please
add more tests. See comment in cookie_test.go


Please don’t reply on this GitHub thread. Visit golang.org/cl/157777.
After addressing review feedback, remember to publish your drafts!

@bradfitz
Copy link
Contributor

Closing so I can take this over on Gerrit.

@bradfitz bradfitz closed this Apr 15, 2019
gopherbot pushed a commit that referenced this pull request Apr 15, 2019
Fixes #29135

Change-Id: I4c10b0395047775e8488b8b0f00f74a7fa01b86c
GitHub-Last-Rev: 1209770
GitHub-Pull-Request: #29728
Reviewed-on: https://go-review.googlesource.com/c/go/+/157777
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net/http: useless string replace operation in Cookie.String
4 participants