Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestLookupGmailTXT failing on Plan 9 #29722

Open
0intro opened this issue Jan 13, 2019 · 5 comments
Open

net: TestLookupGmailTXT failing on Plan 9 #29722

0intro opened this issue Jan 13, 2019 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9
Milestone
Unplanned

Comments

@0intro
Copy link
Member

0intro commented Jan 13, 2019

Since CL 157638, TestLookupGmailTXT is failing on Plan 9.

--- FAIL: TestLookupGmailTXT (0.01s)
    lookup_test.go:248: got [globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=]; want a record containing spf, google.com
    lookup_test.go:248: got [globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=]; want a record containing spf, google.com
FAIL
FAIL	net	28.014s

See https://build.golang.org/log/10777f5ddff9d26836ac135c8c451166efa529ca
@0intro 0intro added this to the Go1.12 milestone Jan 13, 2019
@0intro 0intro self-assigned this Jan 13, 2019
@0intro
Copy link
Member Author

0intro commented Jan 13, 2019

This is related to issue #22857.

@0intro
Copy link
Member Author

0intro commented Jan 13, 2019 •
edited
Loading

The Plan 9 DNS resolver (ndb/dns) only returns a single TXT record, so the TXT request on gmail.com returns either the SPF or the S/MIME record depending on the machine on which ndb/dns is run.

cpu% ndb/dnsquery
> gmail.com txt
gmail.com txt	v=spf1 redirect=_spf.google.com

cpu% ndb/dnsquery
> gmail.com txt
gmail.com txt globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/157737 mentions this issue: net: skip TestLookupGmailTXT on Plan 9

gopherbot pushed a commit that referenced this issue Jan 14, 2019
@0intro
net: skip TestLookupGmailTXT on Plan 9
4e8aaf6 
CL 157638 updated TestLookupGmailTXT. However, this
test is failing on Plan 9, because the DNS resolver
(ndb/dns) only returns a single TXT record.

Updates #29722.

Change-Id: I01cd94e6167902361c3f5d615868f6f763a31fb1
Reviewed-on: https://go-review.googlesource.com/c/157737
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz bradfitz modified the milestones: Go1.12, Unplanned Jan 14, 2019
@fhs
Copy link
Contributor

fhs commented Feb 25, 2021 •
edited
Loading

Update: 9front can return multiple txt records, but there is a bug with caching. You lose the SPF record after it expires.

cpu% ndb/dnsdebug
> gmail.com txt
....
----------------------------
answer gmail.com                        5 min           txt   v=spf1 redirect=_spf.google.com
answer gmail.com                        1 hr            txt   globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=
----------------------------

cpu% ndb/dnsquery
> gmail.com txt
gmail.com txt v=spf1 redirect=_spf.google.com
gmail.com txt globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=
> [wait 5 minutes here]
> gmail.com txt
gmail.com txt globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=
>

@gopherbot please add label OS-Plan9

@jaredpar jaredpar mentioned this issue Apr 22, 2021
Closed
@dagood dagood mentioned this issue Apr 22, 2021
Open
@rsc rsc unassigned 0intro Jun 23, 2022
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 23, 2022
@rsc rsc mentioned this issue Mar 15, 2023
Closed
@oridb
Copy link
Contributor

oridb commented Mar 15, 2023 •
edited
Loading

Confirmed, the multiple txt records work on 9front. I can't reproduce the SPF record going missing; it may have been fixed in (https://git.9front.org/plan9front/plan9front/df66e62842f020b558f556a0df05135d96b5908b/commit.html).

In the future, it would be helpful to get system bug reports sent to 9front@9front.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@bradfitz @cagedmantis @fhs @oridb @0intro @gopherbot