Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: align style of test comments in multi_test.go #29705

Closed
wants to merge 1 commit into from

Conversation

dphan72
Copy link
Contributor

@dphan72 dphan72 commented Jan 12, 2019

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 12, 2019
@gopherbot
Copy link

This PR (HEAD: 6a6cc71) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157642 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Matt Layher:

Patch Set 1: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=68a2b878


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/68a2b878/linux-amd64_9191ef31.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

7 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/68a2b878/linux-amd64_9191ef31.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/68a2b878/windows-386-2008_2d4c9ea7.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/68a2b878/windows-amd64-2016_7b2317d4.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/68a2b878/freebsd-amd64-12_0_b4caf9ab.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/68a2b878/openbsd-amd64-64_85b36f5d.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/68a2b878/linux-386_08b21235.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/68a2b878/linux-amd64-race_6677638b.log

Consult https://build.golang.org/ to see whether they are new failures.


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 32fbd63) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157642 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Derek Phan:

Patch Set 2:

Patch Set 1: TryBot-Result-1

7 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/68a2b878/linux-amd64_9191ef31.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/68a2b878/windows-386-2008_2d4c9ea7.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/68a2b878/windows-amd64-2016_7b2317d4.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/68a2b878/freebsd-amd64-12_0_b4caf9ab.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/68a2b878/openbsd-amd64-64_85b36f5d.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/68a2b878/linux-386_08b21235.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/68a2b878/linux-amd64-race_6677638b.log

Consult https://build.golang.org/ to see whether they are new failures.

Looks like my branch was stale. I've rebased it and updated the PR.


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 2: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=63dc55f3


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/157642.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 26, 2019
Change-Id: Ic93a084311de46461ed3b30f4ac2fe11311e74d7
GitHub-Last-Rev: 32fbd63
GitHub-Pull-Request: #29705
Reviewed-on: https://go-review.googlesource.com/c/157642
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/157642 has been merged.

@gopherbot gopherbot closed this Feb 26, 2019
@dphan72 dphan72 deleted the io-test-comments branch March 18, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants