New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json: Add InputOffset for stream byte offset access #29686

Closed

sheerun wants to merge 1 commit into golang:master from sheerun:json-offset

sheerun commented Jan 11, 2019 •

edited

I'm sending proposal along with pull request, please don't feel I'm trying to force anything.

Use case: I'm trying to index entries in JSON file by their byte offset position for random access

This pull request makes offset method public and changes its name to InputOffset to match XML's decoder API: https://golang.org/pkg/encoding/xml/#Decoder.InputOffset

Reference to proposal: #29688


          encoding/json: add InputOffset for stream byte offset access

b046645

googlebot added the cla: yes label

gopherbot commented Jan 11, 2019

This PR (HEAD: b046645) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157519 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Jan 11, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jan 11, 2019

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

I'll mark this CL on hold until the proposal is approved.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jan 11, 2019

Message from Brad Fitzpatrick:

Patch Set 1:

Please reference the proposal GitHub issue from this commit message.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

sheerun mentioned this pull request

proposal: encoding/json: add InputOffset to json decoder #29688

Closed

gopherbot commented Aug 29, 2019

Message from Daniel Martí:

Patch Set 2:

The proposal was accepted. Adam, can you update the CL as per Brad's comments and rebase?

Also, please follow the commit message best practices.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch from 53bd915 to 6139019 Compare

October 3, 2019 21:09

gopherbot commented Oct 11, 2019

Message from Ian Lance Taylor:

Patch Set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 11, 2019

Message from Ian Lance Taylor:

Patch Set 4: Patch Set 3 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 11, 2019

Message from Ian Lance Taylor:

Patch Set 4: Run-TryBot+1

A new CL https://golang.org/cl/200677 has been sent. Adam, do you want to update the

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 11, 2019

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=510ac3ef

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 11, 2019

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on windows-386-2008:
See https://storage.googleapis.com/go-build-log/510ac3ef/windows-386-2008_74c6e707.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 11, 2019

Message from Ian Lance Taylor:

Patch Set 5:

OK, I guess I can't change the commit message, as Gerritbot will just change it back.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157519.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 11, 2019

This PR is being closed because golang.org/cl/157519 has been abandoned.

Replaced by CL 200677.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment