Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal: contains note about deprecated GOCACHE=off #29680

Closed
thaJeztah opened this issue Jan 11, 2019 · 2 comments
Closed

cmd/go/internal: contains note about deprecated GOCACHE=off #29680

thaJeztah opened this issue Jan 11, 2019 · 2 comments

Comments

@thaJeztah
Copy link
Contributor

What version of Go are you using (go version)?

$ go version 1.12beta2

Does this issue reproduce with the latest release?

Yes, on 1.12beta2

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

Read the documentation at https://tip.golang.org/cmd/go/#hdr-Build_and_test_caching and notice it mentioned GOCACHE=off

Setting GOCACHE=off is no longer allowed in upcoming releases of Go. As described
in the Go 1.11 release notes:

Go 1.11 will be the last release to support setting the environment variable
GOCACHE=off to disable the build cache, introduced in Go 1.10. Starting in Go
1.12, the build cache will be required, as a step toward eliminating
$GOPATH/pkg.

Setting GOCACHE=off now produces an error:

build cache is disabled by GOCACHE=off, but required as of Go 1.12

This line should be removed;

You can set the variable to 'off' to disable the cache.

What did you expect to see?

No mention 😉

What did you see instead?

See above

@thaJeztah
Copy link
Contributor Author

I'm preparing a pull-request for this

thaJeztah added a commit to thaJeztah/go that referenced this issue Jan 11, 2019
Fixes golang#29680

Setting GOCACHE=off is no longer allowed in upcoming releases of Go. As described
in the Go 1.11 release notes:

> Go 1.11 will be the last release to support setting the environment variable
> `GOCACHE=off` to disable the build cache, introduced in Go 1.10. Starting in Go
> 1.12, the build cache will be required, as a step toward eliminating
> `$GOPATH/pkg`.

Setting `GOCACHE=off` now produces an error:

    build cache is disabled by GOCACHE=off, but required as of Go 1.12

This patch removes mention of `GOCACHE=off` from the help/docs.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/go that referenced this issue Jan 11, 2019
Fixes golang#29680

This patch removes mention of `GOCACHE=off` from the help/docs.

Setting GOCACHE=off is no longer allowed in upcoming releases of Go. As
described in the Go 1.11 release notes:

> Go 1.11 will be the last release to support setting the environment
> variable `GOCACHE=off` to disable the build cache, introduced in Go 1.10.
> Starting in Go 1.12, the build cache will be required, as a step toward
> eliminating `$GOPATH/pkg`.

Setting `GOCACHE=off` now produces an error:

    build cache is disabled by GOCACHE=off, but required as of Go 1.12
@gopherbot
Copy link

Change https://golang.org/cl/157517 mentions this issue: cmd/go/internal: remove note about GOCACHE=off

thaJeztah added a commit to thaJeztah/go that referenced this issue Jan 11, 2019
Fixes golang#29680

This patch removes mention of `GOCACHE=off` from the help/docs.

Setting GOCACHE=off is no longer allowed in upcoming releases of Go. As
described in the Go 1.11 release notes:

> Go 1.11 will be the last release to support setting the environment
> variable `GOCACHE=off` to disable the build cache, introduced in Go 1.10.
> Starting in Go 1.12, the build cache will be required, as a step toward
> eliminating `$GOPATH/pkg`.

Setting `GOCACHE=off` now produces an error:

    build cache is disabled by GOCACHE=off, but required as of Go 1.12
thaJeztah added a commit to thaJeztah/go that referenced this issue Jan 11, 2019
Setting GOCACHE=off is no longer allowed in upcoming releases of Go.

Fixes golang#29680
@golang golang locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants