net: support single-request resolv.conf option in pure Go resolver #29661

jfbus · 2019-01-10T18:09:50Z

There is a DNS resolution issue in Kubernetes (UDP response packets get dropped due to a race in conntrack between the parallel A and AAAA queries, causing timeouts in DNS queries).

A workaround is to enable single-request / single-request-reopen in resolv.conf in order to use sequential A and AAAA queries instead of parallel queries.

With this PR, the pure Go resolver searches for "single-request" and "single-request-reopen" in resolv.conf and send A and AAAA queries sequentially when found.

Fixes #29644

gopherbot · 2019-01-10T18:12:17Z

This PR (HEAD: 2fb6da5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157377 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-02T04:47:19Z

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-02T04:47:57Z

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=01e4ec79

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-02T04:54:08Z

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on linux-386:
See https://storage.googleapis.com/go-build-log/01e4ec79/linux-386_7ff1e6bf.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-02T04:54:50Z

Message from Brad Fitzpatrick:

Patch Set 2: Patch Set 1 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-02T04:54:51Z

Message from Brad Fitzpatrick:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-02T04:55:33Z

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0e58454d

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-02T04:57:14Z

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

7 of 19 TryBots failed:
Failed on linux-386: https://storage.googleapis.com/go-build-log/01e4ec79/linux-386_7ff1e6bf.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/01e4ec79/freebsd-amd64-12_0_70e1bc7f.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/01e4ec79/windows-386-2008_7fe4af9a.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/01e4ec79/linux-amd64_2233095a.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/01e4ec79/openbsd-amd64-64_bb68c095.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/01e4ec79/windows-amd64-2016_1376eae8.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/01e4ec79/linux-amd64-race_a676ebb5.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-02T05:06:24Z

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-26T13:56:31Z

Message from Jean-François Bustarret:

Patch Set 2:

Gentle ping; Brad; Mikio; The code is ready to review. Thanks !

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-26T17:39:07Z

Message from Brad Fitzpatrick:

Patch Set 3: Patch Set 2 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-26T17:39:08Z

Message from Brad Fitzpatrick:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-26T17:39:09Z

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e7b25020

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-26T17:44:21Z

Message from Brad Fitzpatrick:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-26T17:47:25Z

Message from Gobot Gobot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-26T18:22:03Z

This PR (HEAD: d481acf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157377 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-26T18:32:06Z

Message from Jean-François Bustarret:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T09:14:20Z

Message from Jean-François Bustarret:

Patch Set 4:

Gentle ping Brad & co: the code is ready for review. Thanks !

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T14:57:09Z

Message from Brad Fitzpatrick:

Patch Set 4: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T14:57:11Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5fff4e87

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T15:01:26Z

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on misc-vet-vetall:
See https://storage.googleapis.com/go-build-log/5fff4e87/misc-vet-vetall_33a7c4bb.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T15:08:10Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T15:08:11Z

Message from Brad Fitzpatrick:

Patch Set 5: Patch Set 4 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T15:08:12Z

Message from Brad Fitzpatrick:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T15:08:12Z

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=7adfbb89

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-16T15:16:04Z

Message from Gobot Gobot:

Patch Set 5: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-17T09:42:33Z

Message from Jean-François Bustarret:

Patch Set 5:

Is this mergeable ? After merging, my plan is to rebase https://go-review.googlesource.com/c/go/+/156366 to fix conflicts. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157377.
After addressing review feedback, remember to publish your drafts!

There is a DNS resolution issue in Kubernetes (UDP response packets get dropped due to a race in conntrack between the parallel A and AAAA queries, causing timeouts in DNS queries). A workaround is to enable single-request / single-request-reopen in resolv.conf in order to use sequential A and AAAA queries instead of parallel queries. With this PR, the pure Go resolver searches for "single-request" and "single-request-reopen" in resolv.conf and send A and AAAA queries sequentially when found. Fixes #29644 Change-Id: I906b3484008c1b9adf2e3e9241ea23767e29df59 GitHub-Last-Rev: d481acf GitHub-Pull-Request: #29661 Reviewed-on: https://go-review.googlesource.com/c/go/+/157377 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

gopherbot · 2019-04-17T14:43:49Z

This PR is being closed because golang.org/cl/157377 has been merged.

net: support single-request resolv.conf option in pure Go resolver

2fb6da5

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 10, 2019

net/dnsclient_unix: rename racer to result

d481acf

gopherbot closed this Apr 17, 2019

This was referenced Apr 18, 2019

DNS intermittent delays of 5s kubernetes/kubernetes#56903

Closed

DNS Issue gliderlabs/docker-alpine#255

Open

negbie mentioned this pull request Mar 10, 2020

Docker in k8s sipcapture/heplify#160

Closed

mjsabby mentioned this pull request Aug 15, 2020

System.Net.Dns does not always resolve "" and the system's own hostname on Unix dotnet/runtime#36849

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: support single-request resolv.conf option in pure Go resolver #29661

net: support single-request resolv.conf option in pure Go resolver #29661

jfbus commented Jan 10, 2019

gopherbot commented Jan 10, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 17, 2019

gopherbot commented Apr 17, 2019

net: support single-request resolv.conf option in pure Go resolver #29661

net: support single-request resolv.conf option in pure Go resolver #29661

Conversation

jfbus commented Jan 10, 2019

gopherbot commented Jan 10, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 2, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Mar 26, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 16, 2019

gopherbot commented Apr 17, 2019

gopherbot commented Apr 17, 2019