Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestLoadImportsGraph is failing on s390x #29660

Closed
dmitshur opened this issue Jan 10, 2019 · 2 comments
Closed

x/tools/go/packages: TestLoadImportsGraph is failing on s390x #29660

dmitshur opened this issue Jan 10, 2019 · 2 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

The TestLoadImportsGraph test is failing on s390x on latest x/tools commit (golang/tools@51295c7). It can be seen at https://build.golang.org.

It happens with Go on latest tip (44cf595), as well as with latest release-branch.go.1.11 (e39e43d).

--- FAIL: TestLoadImportsGraph (1.49s)
    --- FAIL: TestLoadImportsGraph/GOPATH (0.61s)
        packages_test.go:191: golang.org/fake/subdir/d.test.Srcs = [4302876da86a8aae0c1669924daa223cafca60ef49ccaa060ae37e778d18f218-d], want [0.go]
    --- FAIL: TestLoadImportsGraph/Modules (0.89s)
        packages_test.go:191: golang.org/fake/subdir/d.test.Srcs = [4302876da86a8aae0c1669924daa223cafca60ef49ccaa060ae37e778d18f218-d], want [0.go]
FAIL
FAIL	golang.org/x/tools/go/packages	20.935s

See full log at https://build.golang.org/log/dae7ea9d26e4fe76c9ccd619842295c09ce5d6e7.

There's a very good chance this is the same issue as #29445 (/cc @mvdan), but this issue is specifically about the s390x failure, which we need to fix for #11811.
@gopherbot gopherbot added this to the Unreleased milestone Jan 10, 2019
@dmitshur dmitshur mentioned this issue Jan 10, 2019
Open
@matloob
Copy link
Contributor

matloob commented Jan 10, 2019

I'll wait to see if @mvdan's CL fixes this once it's submitted. If not, we'll have to debug it on a s390x machine. (I might get to "hack into a mainframe"!)

@julieqiu julieqiu added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 11, 2019
@dmitshur
Copy link
Contributor Author

CL 156977 has fixed the issue for s390x as well. It must've been using a custom GOCACHE all along, before all the other environments started to as well.

Thank you @mvdan and @matloob!

@golang golang locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @julieqiu @gopherbot @matloob