Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc/redirect: offer Gerrit/Rietveld CL disambiguation when needed [1.11 backport] #29645

Closed
gopherbot opened this issue Jan 10, 2019 · 2 comments
Closed

x/tools/godoc/redirect: offer Gerrit/Rietveld CL disambiguation when needed [1.11 backport] #29645

gopherbot opened this issue Jan 10, 2019 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.11.6

Comments

@gopherbot
Copy link

gopherbot commented Jan 10, 2019 •
edited by dmitshur

@dmitshur requested issue #28836 to be considered for backport to the next 1.11 minor release.

@gopherbot Please backport to Go 1.11, so this change can be deployed to golang.org.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 10, 2019
@gopherbot gopherbot mentioned this issue Jan 10, 2019
Closed
@gopherbot gopherbot modified the milestones: Unreleased, Go1.11.5 Jan 10, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/157237 mentions this issue: [release-branch.go1.11] godoc/redirect: display Gerrit/Rietveld CL disambiguation page when needed

@gopherbot
Copy link
Author

Closed by merging 2646b7dc2e7ff735923a7b8bb61b3cd1f059cb0d to release-branch.go1.11.

gopherbot pushed a commit to golang/tools that referenced this issue Jan 10, 2019
@dmitshur
[release-branch.go1.11] godoc/redirect: display Gerrit/Rietveld CL di…
2646b7d 
…sambiguation page when needed

For CL numbers that are determined to be Rietveld CLs, instead of
immediately redirecting, check whether a Gerrit CL with the same
number also exists. Do so by querying the Gerrit API and caching
the existing CLs. If both exist, display a very simple disambiguation
HTML page.

Cache Gerrit CLs that exist, to avoid querying the remote API server
more than once per CL. We can't cache Gerrit CLs that don't exist,
since they might get created in the future.

Fixes golang/go#29645

Change-Id: I08c32dc82a0136788337c5c32028e87428e8d81e
Reviewed-on: https://go-review.googlesource.com/c/157237
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@julieqiu julieqiu modified the milestones: Go1.11.5, Go1.11.6 Jan 23, 2019
@golang golang locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.11.6
Development

No branches or pull requests
2 participants
@julieqiu @gopherbot