Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: don't try trybots for oauth2, even for 1.10 and 1.11 branches #29637

Closed
bradfitz opened this issue Jan 9, 2019 · 1 comment
Closed

x/build/cmd/coordinator: don't try trybots for oauth2, even for 1.10 and 1.11 branches #29637

bradfitz opened this issue Jan 9, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jan 9, 2019

See https://go-review.googlesource.com/c/oauth2/+/157137 in which we run exactly 2 trybots for oauth2: the 1.10 and 1.11 branches, but not tip or anything else.

This is a regression from fixing #17626

That oauth2 (or packages with non-golang.org/x/ deps) isn't compatible with the coordinator is #14594

/cc @dmitshur @bcmills
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 9, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jan 9, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 9, 2019
@bradfitz bradfitz self-assigned this Jan 10, 2019
@gopherbot
Copy link

Change https://golang.org/cl/157438 mentions this issue: cmd/coordinator: support testing subrepos that use modules

@golang golang locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot