Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: CL 156379 causes deadlocks on FreeBSD 10.3 builders #29633

Closed
bcmills opened this issue Jan 9, 2019 · 4 comments
Closed

os: CL 156379 causes deadlocks on FreeBSD 10.3 builders #29633

bcmills opened this issue Jan 9, 2019 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD release-blocker
Milestone
Go1.12

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 9, 2019

https://golang.org/cl/156379 (which updates #19093) seems to be causing consistent deadlocks in the FreeBSD 10.3 builders:
https://build.golang.org/log/6e053738a50b6d2783d82146712ea469501a63a3
https://build.golang.org/log/dd23083ba54882a43e2d70fcf984722df0191e61
https://build.golang.org/log/6117379f9204b491204d9412db024eb95847248f
https://build.golang.org/log/6087ce300fadc2b1461dffbbfb5171d70fad965f

It is not obvious to me whether this should block the 1.12 release: it seems the 10.3 builders are flaky in general (see #25289). If not, please, remove the release-blocker label.

CC @ianlancetaylor @paulzhol @tklauser
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Jan 9, 2019
@bcmills bcmills added this to the Go1.12 milestone Jan 9, 2019
@ianlancetaylor
Copy link
Contributor

According to the release notes Go 1.12 should still support FreeBSD 10, so perhaps https://golang.org/cl/156379 was overly optimistic.

@gopherbot
Copy link

Change https://golang.org/cl/157099 mentions this issue: os: always treat files as unpollable on FreeBSD

@ianlancetaylor
Copy link
Contributor

CL link doesn't work due to #28836, see https://go-review.googlesource.com/c/go/+/157099.

@dmitshur dmitshur mentioned this issue Jan 9, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/165801 mentions this issue: os: drop special case for FreeBSD 10.4 in newFile

gopherbot pushed a commit that referenced this issue Mar 12, 2019
@tklauser
os: drop special case for FreeBSD 10.4 in newFile
21a634e 
Support for FreeBSD 10 will be dropped with Go 1.13, so revert the
workaround introduced in CL 157099.

Updates #29633
Updates #27619

Change-Id: I1a2e50d3f807a411389f3db07c0f4535a590da02
Reviewed-on: https://go-review.googlesource.com/c/go/+/165801
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bcmills bcmills mentioned this issue May 30, 2019
Open
@golang golang locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD release-blocker
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@ianlancetaylor @bcmills @gopherbot