New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: remove init() to fix precedence issue when setting debug mod info #29630

Closed

vearutop wants to merge 1 commit into golang:master from vearutop:build-info-init

Contributor

vearutop commented Jan 9, 2019

Fixes #29628


          remove init function in __debug_modinfo__ initialization to fix #29628

9275dd8

googlebot added the cla: yes label

gopherbot commented Jan 9, 2019

This PR (HEAD: 9275dd8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157097 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Jan 9, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157097.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jan 9, 2019

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/157097.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jan 9, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=fc705345

Please don’t reply on this GitHub thread. Visit golang.org/cl/157097.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jan 9, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157097.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jan 15, 2019

Message from Russ Cox:

Patch Set 1: Code-Review+2

Thanks for fixing this.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157097.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          cmd/go: remove init() to fix precedence issue when setting debug mod …

3e9c3cf

…info

Fixes #29628

Change-Id: I95dabed797ef7a1a770b6f4219840f653306af7e
GitHub-Last-Rev: 9275dd8
GitHub-Pull-Request: #29630
Reviewed-on: https://go-review.googlesource.com/c/157097
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

gopherbot commented Jan 15, 2019

This PR is being closed because golang.org/cl/157097 has been merged.

gopherbot closed this

vearutop deleted the build-info-init branch

January 19, 2019 13:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment