Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: SYS_IOCTL not defined on Solaris #29581

Closed
dewi-ny-je opened this issue Jan 5, 2019 · 5 comments
Closed

x/sys/unix: SYS_IOCTL not defined on Solaris #29581

dewi-ny-je opened this issue Jan 5, 2019 · 5 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dewi-ny-je
Copy link

As written in #11113 (comment) zsysnum_solaris_amd64.go lacks

SYS_IOCTL = 54

and I get a compilation error when calling on Solaris

unix.SYS_IOCTL
@ianlancetaylor ianlancetaylor changed the title zsysnum_solaris_amd64.go lacks SYS_IOCTL x/sys/unix: SYS_IOCTL not defined on Solaris Jan 6, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jan 6, 2019
@ianlancetaylor
Copy link
Contributor

In fact none of the system call numbers are currently defined on Solaris.

@ianlancetaylor ianlancetaylor added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jan 6, 2019
@bradfitz
Copy link
Contributor

bradfitz commented Jan 8, 2019

System calls are not considered stable ABI on Solaris, so lack of SYS_* constants seems fine.

@dewi-ny-je, what's the real problem, though? SYS_IOCTL not existing is preventing you from doing something else, presumably. What are you trying to compile or do?

@dewi-ny-je dewi-ny-je mentioned this issue Jan 9, 2019
Merged
@AttilaFueloep
Copy link

AttilaFueloep commented Jan 9, 2019 •
edited by bradfitz

Most probably he refers to what is beeing discussed in Bowery/prompt#8 .

@dewi-ny-je Basicaly on Solaris you have to use unix.Ioctl{Get,Set}Termios() and unix.IoctlGetWinsize(), not unix.Syscall(). So unix.SYS_IOCTL isn't needed.

@bradfitz
Copy link
Contributor

bradfitz commented Jan 9, 2019

So, nothing to do here then, right?

@AttilaFueloep
Copy link

Can't speak for @dewi-ny-je , but I think it can be closed.

@golang golang locked and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @dewi-ny-je @ianlancetaylor @gopherbot @AttilaFueloep