Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: tests output misleading proxy_test log spam #29515

Closed
bradfitz opened this issue Jan 2, 2019 · 1 comment
Closed

cmd/go: tests output misleading proxy_test log spam #29515

bradfitz opened this issue Jan 2, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jan 2, 2019

These tests are too noisy:

bradfitz@gdev:~/go/src/cmd/go$ go test -run=TestScript/gcflags_patterns -short -count=1
go test proxy starting
go proxy_test: invalid module path encoding "example.com/invalidpath/v1": malformed module path "example.com/invalidpath/v1": invalid version
go test proxy running at GOPROXY=http://127.0.0.1:32931/mod
PASS
ok      cmd/go  1.866s

Lines 1 & 3 should only be output in verbose mode probably.

Line 2 should never be output. It's complaining about something, but the tests pass, so it obviously wasn't a real problem. It's distracting, especially when I see while debugging unrelated issues.
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 2, 2019
@bradfitz bradfitz added this to the Go1.13 milestone Jan 2, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@johnaoss johnaoss mentioned this issue Sep 6, 2019
Closed
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot
Copy link

Change https://golang.org/cl/227162 mentions this issue: cmd/go: remove output of proxy_test log in tests

@golang golang locked and limited conversation to collaborators Aug 24, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@bradfitz @rsc @andybons @bcmills @gopherbot