Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript gcflags_patterns.txt regexp matches randomly created directory names #29514

Closed
bradfitz opened this issue Jan 2, 2019 · 1 comment
Closed

cmd/go: TestScript gcflags_patterns.txt regexp matches randomly created directory names #29514

bradfitz opened this issue Jan 2, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jan 2, 2019

We've seen this flake a few times now:

https://storage.googleapis.com/go-build-log/c605f218/windows-amd64-2016_ca8be857.log

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/gcflags_patterns (0.08s)
        script_test.go:183: 
....
....
            > ! stderr 'compile.* -e .*-p [^z]'
            FAIL: testdata\script\gcflags_patterns.txt:8: unexpected match for `compile.* -e .*-p [^z]` found in stderr: compile.exe" -o "$WORK\\b001\\_pkg_.a" -trimpath "$WORK\\b001" -e -p z1 -complete -buildid KzFD_iw2H857UIAbyQ-p/KzFD_iw2H857UIAbyQ-p -
            
FAIL
FAIL	cmd/go	199.890s

/cc @FiloSottile
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 2, 2019
@bradfitz bradfitz added this to the Go1.12 milestone Jan 2, 2019
@bcmills
Copy link
Contributor

bcmills commented Jan 8, 2019

Fixed in https://golang.org/cl/156327.

@bcmills bcmills closed this as completed Jan 8, 2019
@bcmills bcmills assigned jayconrod and unassigned bcmills Jan 8, 2019
@bcmills bcmills mentioned this issue Jan 9, 2019
Closed
@golang golang locked and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@bradfitz @jayconrod @bcmills @gopherbot