Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/app: deleted security branches showing up on dashboard #29513

Closed
dmitshur opened this issue Jan 2, 2019 · 2 comments
Closed

x/build/app: deleted security branches showing up on dashboard #29513

dmitshur opened this issue Jan 2, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jan 2, 2019 •
edited

The build dashboard is showing security branches that have been deleted. They shouldn't be showing up.

This is the same issue as #29510, but for the build dashboard rather than trybots. /cc @bradfitz

image
@gopherbot gopherbot added this to the Unreleased milestone Jan 2, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 2, 2019
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 2, 2019
@dmitshur dmitshur self-assigned this Jan 2, 2019
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Jan 2, 2019
@dmitshur
Copy link
Contributor Author

There's no underlying issue in maintner because the build dashboard doesn't use it.

The code that figures out the branches is here. It's not doing anything wrong, it just seems there's an entry for the security branch that exists in the database it queries, from the short amount of time that the security release branch existed.

In future, we can try to adjust security release process to avoid pushing security release branches to origin server (just perform the merge locally and push that). /cc @FiloSottile If that doesn't work out, then we'll need to add to hiddenBranches like in CL 157817.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 14, 2019
@gopherbot
Copy link

Change https://golang.org/cl/157817 mentions this issue: app/appengine: remove the security branches from the build dashboard

@golang golang locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot