Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: new mid-stack inlining tracebacks broke TestNexting #29511

Closed
aclements opened this issue Jan 2, 2019 · 2 comments
Closed

cmd/compile: new mid-stack inlining tracebacks broke TestNexting #29511

aclements opened this issue Jan 2, 2019 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.12

Comments

@aclements
Copy link
Member

CL 152537 broke TestNexting. For example: https://build.golang.org/log/ad327f4df87dc312a4840aa82dccbaf832822120

/cc @dr2chase @randall77
@aclements aclements added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 2, 2019
@aclements aclements added this to the Go1.12 milestone Jan 2, 2019
@aclements aclements mentioned this issue Jan 2, 2019
Closed
@dr2chase
Copy link
Contributor

dr2chase commented Jan 2, 2019

I suspect the resolution is to just update the comparison files, but I think I want to look at a different plan for assigning statement boundaries for 1.13 because this is not-good.

@gopherbot
Copy link

Change https://golang.org/cl/156021 mentions this issue: cmd/compile: Update ssa/debug_test reference files for delve and gdb

@golang golang locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@dr2chase @aclements @gopherbot