-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: incorrect code generation bug when taking slice[:0] [1.11 backport] #29503
Comments
@FiloSottile would you consider this to be a serious issue without a workaround? If so, then we can approve this candidate now that the fix is in. |
Yeah, this is a real miscompilation crash that was apparently detected in a real application. |
It was found by another developer; see #29833. |
So it is safe to assume this did not get into 1.11.5 even that it was approved for cherrypick, am I right? |
Correct, this got pushed to Go 1.11.6 because 1.11.5 was a security-only release. |
hi, When will the Go 1.11.6 be released? |
@cherrymui Would you like to mail a backport of CL 156019 onto the |
Done. CL https://go-review.googlesource.com/c/go/+/163724. Thanks. |
Change https://golang.org/cl/163724 mentions this issue: |
Thank you @cherrymui! |
Closed by merging c8c897a to release-branch.go1.11. |
…erflow in prove pass In the case of x+d >= w, where d and w are constants, we are deriving x is within the bound of min=w-d and max=maxInt-d. When there is an overflow (min >= max), we know only one of x >= min or x <= max is true, and we derive this by excluding the other. When excluding x >= min, we did not consider the equal case, so we could incorrectly derive x <= max when x == min. Updates #29502. Fixes #29503. Change-Id: Ia9f7d814264b1a3ddf78f52e2ce23377450e6e8a Reviewed-on: https://go-review.googlesource.com/c/156019 Reviewed-by: David Chase <drchase@google.com> (cherry picked from commit 2e217fa) Reviewed-on: https://go-review.googlesource.com/c/163724 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
@FiloSottile requested issue #29502 to be considered for backport to the next 1.11 minor release.
The text was updated successfully, but these errors were encountered: