New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: textarea text not legible on https://golang.org/ when using Adwaita Dark gnome theme #29482
Comments
CC @andybons |
CC @cnoellekb |
@8i8 how many other sites are broken for you? If you visit https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea do you see the same issue? |
@andybons Yes that is broken too; There is a surprisingly large percentage of the web, for whome the issue is present. Any website that override only one of the default pair, the textarea background colour or the text itself is rendered illegible. The user settings are just that, the user settings; This is OS widgit colour not web specific. I have stopped using the adwaita dark setting whilst working with the documentation, but this is not ideal. The issue occurs in firefox but not in chromium, it would appear that the chromium browser has done something to either detect or simply rectify when this occurs. I personally like the setting, as it keeps the white glare down in what wouldbe low light environments; There is far to much contrast, in any dark theme, when large text areas are #ffffff white. Thank you for your consideration. |
@andybons I have just been investigating the firefox settings and found a force system colours checkbox; This has resolved for the w3schools site but not for golang.org; Still White text on beige. ... I have just reverted firefox back to the default settings as due to attempting to make the go doc's legible i had switched on a theme colour profile; firefox now standard colours and the system set to advaita dark; the w3school's site is readable where as the golang is still light on light. |
Firefox Quantum (64.0.2 (64-bit)) and Chrome both apply their own default styles to the textarea on golang.org. I don’t believe directly stying the textarea is the right solution. Without knowing how gnome’s skinning works it’s difficult to know the best next step. Given that things were broken for a large part of the web until settings were fiddled with, I’m inclined to believe that something is misconfigured or there’s a bug in gnome’s skinning code. |
@andybons UA stylesheets explicitly set a foreground and background color on form inputs. If you leave both as they are, it doesn't matter what those colors are. If you set both explicitly, it doesn't matter what you set them to. If you set one but not the other, it's possible that the two colors fail to contrast. Even if you don't consider this a bug in godoc, you can consider it a feature as setting an explicit color on the textarea makes the site more robust in the face of the myriad ways UA stylesheets can be altered. |
@jimmyfrasche you’re right, and given we explicitly set the background color but not foreground it may be that the gnome skinning is altering the UA stylesheet and causing this issue. Is this how gnome skinning works? |
I don't know how the gnome skinning works. The skin could be replacing the UA stylesheets or installing a custom FF theme or it could be setting some color values in the skin that FF gets reads to compute There are a lot of ways for it to have gone wrong but adding something like |
Yes very few devs pay attention to these defaults UI, is not cutting edge for some reason, which is a shame as it ought to be. Of note: this debian/GNOME setup has extremely good accessibility configurations, clearly a premier concern. |
@8i8 if you’d like to send a change with the fix (including a comment about why we’re explicitly setting a color), I am happy to review. |
@andybons Thank you for your kind consideration; After a little investigation of the setup, which has not yet reveled the origin of these styling options; I am lead to believe that they could be set further upstream, maybe the webserver gas a global template for page headers and styling? Could I run a test version of the site locally so as to be able to see where the cascading effect of styling are taking effect, or not, as the case may be? Thank you. |
@andybons Hi, I having finally found the correct place for this small modification, to the best of my knowledge this is where it be best placed to amend any occurrences of the issue; I have made a pull request: |
Change https://golang.org/cl/158137 mentions this issue: |
Change https://golang.org/cl/160482 mentions this issue: |
golang.org/cl/158137 was missing a corresponding update to static.go. Updates golang/go#29482 Change-Id: I60e059c3f00408c0d41e5284cb3e154fc1515032 Reviewed-on: https://go-review.googlesource.com/c/160482 Reviewed-by: Katie Hockman <katie@golang.org>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
The issue is with the website.
What operating system and processor architecture are you using (
go env
)?Using debian 9.9 with the gnome 3 settings from the standard tweaks menu and firefox-esr.
go env
OutputWhat did you do?
I have the advaita dark theme activated which sets the text background default to a dark colour and the foreground text to a light colour, white.
All text area text, particularly the examples and runnable code on the website is unreadable without my changing my OS setup.
What did you expect to see?
Text.
What did you see instead?
Nothing, unless selected with the mouse.
Fix
This can be easily fixed by adding the following css to style.css:
textarea {
color: #222;
}
I would be very grateful for your attention in this matter, I did take a look for the style sheet but have not managed to find it. Here are two screen shots of the way that the site currently appears in my browser:
Thank you for your attention.
Iain Hill.
The text was updated successfully, but these errors were encountered: