Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/build_runtime_gcflags failing on longtest builder #29395

Closed
ALTree opened this issue Dec 22, 2018 · 3 comments
Closed

cmd/go: TestScript/build_runtime_gcflags failing on longtest builder #29395

ALTree opened this issue Dec 22, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@ALTree
Copy link
Member

ALTree commented Dec 22, 2018

The TestScript harness is currently broken, causing a failure in the cmd/go test suite on the longtest builder. A log:

https://build.golang.org/log/13f2837122b3a012cc7d46fe08e0214ca5ee61fb

The failures started at 0005515 (cmd/go: fix -n output in runtime/internal/atomic).

cc @jayconrod
@ALTree ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 22, 2018
@ALTree ALTree added this to the Go1.12 milestone Dec 22, 2018
@mvdan
Copy link
Member

mvdan commented Dec 23, 2018

That's when the test script was added. Weirdly enough, the test script passes on my machine.

Also, I think the comment on the test script is wrong. It says "See golang.org/issue/26092.", but that issue seems completely unrelated to the build flags bug.

@jayconrod jayconrod self-assigned this Jan 2, 2019
@gopherbot
Copy link

Change https://golang.org/cl/156237 mentions this issue: cmd/go: fix failure in TestScript/build_runtime_gcflags

@jayconrod jayconrod added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 3, 2019
@jayconrod
Copy link
Contributor

This was a misconception on my part. I assumed the tests were using separate caches. This issue could be reproduced by running go build -gcflags=all=-l std before running the test.

The test will now creates its own cache directory.

(Also, fixed the issue URL. Thanks for pointing that out.)

@golang golang locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@jayconrod @mvdan @ALTree @gopherbot