Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: do not complete inside of comments #29370

Closed
stamblerre opened this issue Dec 20, 2018 · 4 comments
Closed

x/tools/internal/lsp: do not complete inside of comments #29370

stamblerre opened this issue Dec 20, 2018 · 4 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

The "." character triggers completion in the LSP, but we should avoid returning completion results when the "." is within a comment.
@gopherbot gopherbot added this to the Unreleased milestone Dec 20, 2018
@stamblerre stamblerre added the Suggested Issues that may be good for new contributors looking for work to do. label Dec 20, 2018
@anjmao
Copy link

anjmao commented Jan 11, 2019

@stamblerre Hi, as this sounds like lower level priority, could I try to solve this issue? I imagine it could be fixed by checking if . was placed at *ast.Comment node.

@stamblerre
Copy link
Contributor Author

@anjmao: yes, absolutely! You're right - I think this is as simple as adding a case for *ast.Comment in golang.org/x/tools/internal/lsp/source.Completion.

@anjmao anjmao mentioned this issue Jan 13, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/157678 mentions this issue: internal/lsp: do not complete inside comments

@anjmao anjmao mentioned this issue Jan 18, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/158538 mentions this issue: internal/lsp: do not complete inside comments

@stamblerre stamblerre reopened this Jan 18, 2019
@golang golang locked and limited conversation to collaborators Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@anjmao @stamblerre @gopherbot