Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys: unix/linux/mksysnum.go is executable as of 2018-12-20 #29369

Closed
anthonyfok opened this issue Dec 20, 2018 · 3 comments
Closed

x/sys: unix/linux/mksysnum.go is executable as of 2018-12-20 #29369

anthonyfok opened this issue Dec 20, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@anthonyfok
Copy link

In the recent commit golang/sys@a5c9d58 "unix/linux: replace "mksysnum.pl" script with a Go program", it seems that mksysnum.go was inadvertently created with mode 100755 (executable) rather than the normal 100644 mode.

This raised a Lintian executable-not-elf-or-script warning while we were updating the x/sys package for Debian:

W: golang-golang-x-sys-dev: executable-not-elf-or-script usr/share/gocode/src/golang.org/x/sys/unix/linux/mksysnum.go

This is a very minor issue, but I thought you might like to know.

Cheers,
Anthony
@gopherbot gopherbot added this to the Unreleased milestone Dec 20, 2018
@gopherbot
Copy link

Change https://golang.org/cl/155417 mentions this issue: unix/linux: set 100644 mode on mksysnum.go

@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 20, 2018
@ALTree
Copy link
Member

ALTree commented Dec 20, 2018

Thanks for the report. I sent a change to set mksysnum.go mode to 644.

@tklauser
Copy link
Member

Thanks for the report and the fix. I missed that during the review of https://golang.org/cl/151377

@golang golang locked and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@tklauser @anthonyfok @ALTree @gopherbot