Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/race: freebsd race builder is broken #29340

Closed
bradfitz opened this issue Dec 19, 2018 · 4 comments
Closed

runtime/race: freebsd race builder is broken #29340

bradfitz opened this issue Dec 19, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@bradfitz
Copy link
Contributor

https://go-review.googlesource.com/c/go/+/153897 broke the FreeBSD race builder.

@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Dec 19, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Dec 19, 2018
@mknyszek
Copy link
Contributor

I see the issue. It's unfortunate because this is a Darwin-specific fix, and I had to add it to mem_bsd.go since the two files were merged together since the last release. That's why this leaks into FreeBSD.

Also, the failure is kind of funny; MAP_FIXED does too good of a job using the arena hints it seems, but I'll investigate and try to figure out a fix ASAP.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 19, 2018

Ohhh, no I see. MAP_FIXED is causing us to map over already mapped space without error. Ugh. This was expected, but I didn't think it would cause issues in tests. That kind of makes sense though; nothing else uses MAP_FIXED.

@gopherbot
Copy link

Change https://golang.org/cl/155097 mentions this issue: runtime: disable TestArenaCollision on Darwin in race mode

@mknyszek
Copy link
Contributor

I put up a change which makes it so that MAP_FIXED is only used if GOOS == "darwin" (so FreeBSD gets fixed) and then disables the test on Darwin in race mode because the test is also likely broken there, it's just that the builder is failing earlier and masking it.

@golang golang locked and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants