Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/json: Marshaling embedded structures which supports custom json.Marshaler interface #29336

Closed
kirill-a-belov opened this issue Dec 19, 2018 · 0 comments
Closed

encoding/json: Marshaling embedded structures which supports custom json.Marshaler interface #29336

kirill-a-belov opened this issue Dec 19, 2018 · 0 comments
Labels
FrozenDueToAge

Comments

@kirill-a-belov
Copy link

kirill-a-belov commented Dec 19, 2018 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.10.3 linux/amd64

Does this issue reproduce with the latest release?

Didn't try.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/kirill/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/kirill/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build489275390=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Try to marshal into json struct which have embended struct with supports custom json.Marshaler interface.
Ex:
struct {
A // Support custom json.Marshaler interface
Field2 string
}

https://play.golang.com/p/wqQV8Mp_11y

What did you expect to see?

All fields of structure.

What did you see instead?

Only fields of embedded structure.
@kirill-a-belov kirill-a-belov changed the title encoding/json: Marshaling embedded structures which supports supports json.Marshaler interface encoding/json: Marshaling embedded structures which supports json.Marshaler interface Dec 19, 2018
@kirill-a-belov kirill-a-belov changed the title encoding/json: Marshaling embedded structures which supports json.Marshaler interface encoding/json: Marshaling embedded structures which supports custom json.Marshaler interface Dec 19, 2018
@golang golang locked and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @kirill-a-belov