Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: close-cherry-pick pass too aggressive #29270

Closed
bradfitz opened this issue Dec 14, 2018 · 3 comments
Closed

x/build/cmd/gopherbot: close-cherry-pick pass too aggressive #29270

bradfitz opened this issue Dec 14, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

Seen on #28673, the gopherbot close-cherry-pick pass is too aggressive:

2018/12/14 20:05:49 got corpus update after 6.071844875s
close-cherry-pick
        https://golang.org/issue/28673  x/net/http2: Transport is leaking streams on broken Body [1.11 backport]

/cc @FiloSottile @dmitshur
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 14, 2018
@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 14, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Dec 14, 2018 •
edited

I think it's missing a gi.HasEvent("reopened") check, to make it not fight humans who might've re-opened the issue. Of course, it will still fight one time (due to #21312), but no more. Will send a CL.

@gopherbot
Copy link

Change https://golang.org/cl/154337 mentions this issue: cmd/gopherbot: don't consider reopened issues in close-cherry-pick task

@dmitshur
Copy link
Contributor

dmitshur commented Jan 7, 2019

I've redeployed gopherbot with the fix.

@bradfitz bradfitz mentioned this issue Feb 3, 2019
Closed
@dmitshur dmitshur mentioned this issue Mar 27, 2019
Open
@golang golang locked and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot