-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/vet: "go vet --shadow" used to work, does not work #29260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suspect this is WAI. See the discussion in #28622, in particular Alan's comment at #28622 (comment). |
@alandonovan Is there an existing shadow checker somewhere that uses the new framework that people can use? |
Marking for 1.12 because if nothing else this needs to be mentioned in the release notes. |
Yes, see
The reason this checker is not included in the new vet is that it was the sole "experimental" checker, and I didn't think it warranted the introduction of the "experimental" concept to the new API. If we can improve the heuristics used by 'shadow' to the point where it would no longer be considered experimental then there's no reason not to add it back to the core vet suite. |
Change https://golang.org/cl/154584 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
Quick reminder to only comment if you have an idea or constructive feedback. A new issue would probably be better too, as this issue is closed and isn't the best place to discuss. In any case, personal opinions and criticism don't add to the thread. |
I have a test runner that calls
go vet --all && go vet --shadow
: https://github.com/kevinburke/go-bindata/blob/master/testdata/MakefileThis test runner breaks on
tip
:I'm not sure if the compatibility guarantee extends to flag arguments, but it's a little frustrating that this program broke and it took some searching to figure out how to fix it. Searching Google yields mostly results that expect "go vet --shadow" to work as previously written.
The text was updated successfully, but these errors were encountered: