Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go get -n prints too much #2926

Closed
gopherbot opened this issue Feb 8, 2012 · 4 comments
Closed

cmd/go: go get -n prints too much #2926

gopherbot opened this issue Feb 8, 2012 · 4 comments
Milestone

Comments

@gopherbot
Copy link

by untheoretic:

1) please as default just "get" the source (security first):

go get code.google.com/p/gosqlite/sqlite

sqlite.go: In function ‘_cgo_98ed2c6f47a0_Cfunc_sqlite3_prepare_v2’:
sqlite.go:290:2: warning: passing argument 5 of ‘sqlite3_prepare_v2’ from
incompatible pointer type [enabled by default]
/usr/include/sqlite3.h:2839:16: note: expected ‘const char **’ but argument is of
type ‘char **’
# code.google.com/p/gosqlite/sqlite
sqlite.go:168[/tmp/go-build983582224/code.google.com/p/gosqlite/sqlite/_obj/sqlite.cgo1.go:171]:
cannot use sleepNs (type int64) as type time.Duration in function argument
sqlite.go:228[/tmp/go-build983582224/code.google.com/p/gosqlite/sqlite/_obj/sqlite.cgo1.go:231]:
undefined: time.Nanoseconds
sqlite.go:328[/tmp/go-build983582224/code.google.com/p/gosqlite/sqlite/_obj/sqlite.cgo1.go:331]:
undefined: strconv.Atoi64
sqlite.go:334[/tmp/go-build983582224/code.google.com/p/gosqlite/sqlite/_obj/sqlite.cgo1.go:337]:
undefined: strconv.Atof64
sqlite.go:351[/tmp/go-build983582224/code.google.com/p/gosqlite/sqlite/_obj/sqlite.cgo1.go:354]:
undefined: time.Nanoseconds

----

2) -x -n should just print the checkout command:

go get -x -n -d code.google.com/p/gosqlite/sqlite
cd .
hg clone -U https://code.google.com/p/gosqlite /nogo/src/code.google.com/p/gosqlite
cd /nogo/src/code.google.com/p/gosqlite
hg tags
cd /nogo/src/code.google.com/p/gosqlite
hg branches
cd /nogo/src/code.google.com/p/gosqlite
hg update default

tree 
.
└── src
    └── code.google.com
        └── p
            └── gosqlite
                └── sqlite
                    └── sqlite.go
----

3) go clean - nothing happens

cd src/code.google.com/p/gosqlite/sqlite
go fix
sqlite.go: fixed time+fileinfo strconv
vi sqlite.go hack hack
go install
# code.google.com/p/gosqlite/sqlite
sqlite.go: In function ‘_cgo_ad8b4114c021_Cfunc_sqlite3_prepare_v2’:
sqlite.go:237:2: warning: passing argument 5 of ‘sqlite3_prepare_v2’ from
incompatible pointer type [enabled by default]
/usr/include/sqlite3.h:2839:16: note: expected ‘const char **’ but argument is of
type ‘char **’

sqlite.go:237 - wrong line (filled issue)

go clean

----

4) please add an option to leave the intermediate files

# github.com/mattn/go-gtk/gtk
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector *_Ctype_GtkProgressBar._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector _Ctype_GtkProgressBar._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: cannot use
&p._ (type *[4]byte) as type *[8]byte in function argument
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector *_Ctype_GtkProgressBar._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector _Ctype_GtkProgressBar._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector *_Ctype_GtkProgressBar._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector _Ctype_GtkProgressBar._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector *_Ctype_GtkFrame._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector _Ctype_GtkFrame._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: ambiguous
selector *_Ctype_GtkFrame._
/tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go:1: too many
errors

vi /tmp/go-build256765935/github.com/mattn/go-gtk/gtk/_obj/_cgo_gotypes.go

oops ...
@rsc
Copy link
Contributor

rsc commented Feb 9, 2012

Comment 1:

Labels changed: added priority-go1, removed priority-triage.

Owner changed to builder@golang.org.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Feb 28, 2012

Comment 2:

Thanks for the suggestions.
1) Sorry, but no.  Use -d if you are worried.
2) Will fix.
3) What do you want go clean to do?
4) There is now a -work option.

@gopherbot
Copy link
Author

Comment 4 by extraterrestrial.neighbour:

1) Let's hope no kid can trick the compiler/linker to wipe your home.
3) I think if build is useless for building packages, so right, there
is nothing to clean.
4) Thanks!

@rsc
Copy link
Contributor

rsc commented Mar 1, 2012

Comment 5:

This issue was closed by revision b03a5f6.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants