-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: remove badgerbadgerbadger optimization? #29242
Comments
Fine by me. Might want to double-check that the stdlib doesn't have any (except a possible test for this optimization). |
SGTM |
That is a very common pattern... in bourne shell. Where the idiom is Also why is the function not called |
It's a subroutine of the vestigially-named See also #27167. |
Change https://golang.org/cl/163728 mentions this issue: |
For the record, this was here because of https://groups.google.com/g/golang-nuts/c/7Ks1iq2s7FA/m/rS60bS4aMi4J. |
From walk.go:
I've always been skeptical that anyone writes code that matches this pattern; I'd like to remove it.
Thoughts/objections?
cc @mdempsky @randall77
The text was updated successfully, but these errors were encountered: