Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math: argument reduction inaccurate on s390x for huge inputs for Sin/Cos/SinCos/Tan #29240

Closed
griesemer opened this issue Dec 13, 2018 · 2 comments
Closed

math: argument reduction inaccurate on s390x for huge inputs for Sin/Cos/SinCos/Tan #29240

griesemer opened this issue Dec 13, 2018 · 2 comments
Assignees
@srinivas-pokala
Labels
arch-s390x Issues solely affecting the s390x architecture. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@griesemer
Copy link
Contributor

Currently, tests for huge arguments for Sin/Cos/SinCos/Tan are disabled for s390x because the respective assembly routines don't reduce input arguments accurately enough.

The assembly routines are fixed; or better, the pure Go code should be used instead if there's no significant performance difference.

See also #29221 for more details.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 13, 2018
@griesemer griesemer added this to the Go1.13 milestone Dec 13, 2018
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@mundaym mundaym added the arch-s390x Issues solely affecting the s390x architecture. label Dec 2, 2020
@gopherbot
Copy link

Change https://go.dev/cl/469635 mentions this issue: math: huge argument handling for sin/cos in s390x

@srinivas-pokala srinivas-pokala self-assigned this Feb 20, 2023
@gopherbot
Copy link

Change https://go.dev/cl/509675 mentions this issue: math: enable huge argument tests on s390x

gopherbot pushed a commit that referenced this issue Jul 31, 2023
@srinivas-pokala @randall77
math: enable huge argument tests on s390x
a37da52 
new s390x assembly implementation of Sin/Cos/SinCos/Tan handle huge argument
test's.

Updates #29240

Change-Id: I9f22d9714528ef2af52c749079f3727250089baf
Reviewed-on: https://go-review.googlesource.com/c/go/+/509675
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srinivas-pokala srinivas-pokala

Labels
arch-s390x Issues solely affecting the s390x architecture. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@rsc @andybons @griesemer @gopherbot @billotosyr @mundaym @srinivas-pokala