Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vendor: build broken on linux/arm after x/sys/unix update #29224

Closed
ALTree opened this issue Dec 13, 2018 · 4 comments
Closed

cmd/vendor: build broken on linux/arm after x/sys/unix update #29224

ALTree opened this issue Dec 13, 2018 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.12

Comments

@ALTree
Copy link
Member

ALTree commented Dec 13, 2018

CL 153838 re-vendored golang.org/x/sys/unix, and that broke the linux/arm builder:

# cmd/vendor/golang.org/x/sys/unix_test [cmd/vendor/golang.org/x/sys/unix.test]
go/src/cmd/vendor/golang.org/x/sys/unix/syscall_linux_test.go:471:8: undefined: unix.SyncFileRange
go/src/cmd/vendor/golang.org/x/sys/unix/syscall_linux_test.go:480:8: undefined: unix.SyncFileRange
FAIL	cmd/vendor/golang.org/x/sys/unix [build failed]
2018/12/13 04:17:37 Failed: exit status 2

example:
https://build.golang.org/log/4fb5c10b30bdaa9b04a1b048ae9043afcd8160df

cc @4a6f656c
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 13, 2018
@ALTree ALTree added this to the Go1.12 milestone Dec 13, 2018
@ALTree ALTree changed the title cmd/vendor: build broken on linux/arm after x/sys/unix vendoring cmd/vendor: build broken on linux/arm after x/sys/unix update Dec 13, 2018
@bcmills
Copy link
Contributor

bcmills commented Dec 13, 2018 •
edited

CC @bradfitz @tklauser

@bradfitz
Copy link
Contributor

@tklauser already added this to x/sys/unix in https://go-review.googlesource.com/c/sys/+/153939

This now needs to be re-vendored.

@gopherbot
Copy link

Change https://golang.org/cl/154117 mentions this issue: cmd/vendor: update vendored golang.org/x/sys/unix

@tklauser
Copy link
Member

Before revendoring x/sys/unix I'd like to submit https://golang.org/cl/153938 to unbreak aix in the same update.

@golang golang locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
5 participants
@bradfitz @tklauser @ALTree @bcmills @gopherbot