Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/callgraph: TestCallGraph fails on release-branch.go1.11 #29201

Closed
andybons opened this issue Dec 12, 2018 · 4 comments
Closed

x/tools/cmd/callgraph: TestCallGraph fails on release-branch.go1.11 #29201

andybons opened this issue Dec 12, 2018 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@andybons
Copy link
Member

Example failure below:

linux-amd64 at d1882c986673b5bd5fb6775548990d4e11917c1e building tools at a26575a1e6c3e22e2cea09d7adb633e4af243750

:: Running /workdir/go/src/make.bash with args ["/workdir/go/src/make.bash"] and env ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-jessie-rn9012c78" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOBIN="] in dir /workdir/go/src

Building Go cmd/dist using /go1.4.
Building Go toolchain1 using /go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for linux/amd64.
---
Installed Go for linux/amd64 in /workdir/go
Installed commands in /workdir/go/bin
ok  	golang.org/x/tools/benchmark/parse	0.031s
ok  	golang.org/x/tools/blog	0.078s
?   	golang.org/x/tools/blog/atom	[no test files]
ok  	golang.org/x/tools/cmd/benchcmp	0.026s
ok  	golang.org/x/tools/cmd/bundle	0.056s
/workdir/go/src/sync/atomic/asm.s:7:1: illegal character U+0023 '#'
-: package ; expected atomic
/workdir/go/src/internal/cpu/cpu_x86.s:7:1: illegal character U+0023 '#'
-: package ; expected cpu
/workdir/go/src/runtime/internal/atomic/asm_amd64.s:8:1: illegal character U+0023 '#'
-: package ; expected atomic
/workdir/go/src/internal/bytealg/compare_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/count_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/equal_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/index_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/indexbyte_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected bytealg
-: package ; expected bytealg
-: package ; expected bytealg
-: package ; expected bytealg
-: package ; expected bytealg
/workdir/go/src/math/asin_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/asinh_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/atan2_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/atan_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/cbrt_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/dim_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/erf_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/exp2_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/exp_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/expm1_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/floor_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/frexp_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/hypot_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/ldexp_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/log10_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/log1p_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/log_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/mod_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/modf_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/pow_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/remainder_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/sin_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/sinh_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/sqrt_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/tan_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
/workdir/go/src/runtime/asm.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/asm_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/duff_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/memclr_amd64.s:7:1: illegal character U+0023 '#'
/workdir/go/src/runtime/memmove_amd64.s:28:1: illegal character U+0023 '#'
/workdir/go/src/runtime/rt0_linux_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/sys_linux_amd64.s:9:1: illegal character U+0023 '#'
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
/workdir/go/src/reflect/asm_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected reflect
/workdir/go/src/syscall/asm_linux_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected syscall
/workdir/go/src/strings/strings.s:5:54: expected ';', found 'EOF' (and 2 more errors)
-: package ; expected strings
/workdir/go/src/hash/crc32/crc32_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected crc32
/workdir/go/src/runtime/debug/debug.s:9:55: expected ';', found 'EOF' (and 2 more errors)
-: package ; expected debug
/workdir/go/src/sync/atomic/asm.s:7:1: illegal character U+0023 '#'
-: package ; expected atomic
/workdir/go/src/internal/cpu/cpu_x86.s:7:1: illegal character U+0023 '#'
-: package ; expected cpu
/workdir/go/src/internal/bytealg/compare_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/count_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/equal_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/index_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/internal/bytealg/indexbyte_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected bytealg
-: package ; expected bytealg
-: package ; expected bytealg
-: package ; expected bytealg
-: package ; expected bytealg
/workdir/go/src/runtime/internal/atomic/asm_amd64.s:8:1: illegal character U+0023 '#'
-: package ; expected atomic
/workdir/go/src/math/asin_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/asinh_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/atan2_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/atan_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/cbrt_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/dim_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/erf_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/exp2_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/exp_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/expm1_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/floor_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/frexp_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/hypot_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/ldexp_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/log10_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/log1p_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/log_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/mod_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/modf_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/pow_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/remainder_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/sin_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/sinh_stub.s:7:1: illegal character U+0023 '#'
/workdir/go/src/math/sqrt_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/math/tan_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
-: package ; expected math
/workdir/go/src/runtime/asm.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/asm_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/duff_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/memclr_amd64.s:7:1: illegal character U+0023 '#'
/workdir/go/src/runtime/memmove_amd64.s:28:1: illegal character U+0023 '#'
/workdir/go/src/runtime/rt0_linux_amd64.s:5:1: illegal character U+0023 '#'
/workdir/go/src/runtime/sys_linux_amd64.s:9:1: illegal character U+0023 '#'
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
-: package ; expected runtime
/workdir/go/src/syscall/asm_linux_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected syscall
/workdir/go/src/strings/strings.s:5:54: expected ';', found 'EOF' (and 2 more errors)
-: package ; expected strings
/workdir/go/src/hash/crc32/crc32_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected crc32
/workdir/go/src/reflect/asm_amd64.s:5:1: illegal character U+0023 '#'
-: package ; expected reflect
/workdir/go/src/runtime/debug/debug.s:9:55: expected ';', found 'EOF' (and 2 more errors)
-: package ; expected debug
--- FAIL: TestCallgraph (4.53s)
    main_test.go:77: callgraph("rta", true): missing edge: pkg.test.main --> testing.MainStart
    main_test.go:77: callgraph("rta", true): missing edge: testing.runExample --> pkg.Example
    main_test.go:77: callgraph("rta", true): missing edge: pkg.Example --> (pkg.C).f
    main_test.go:82: got:
         pkg.main2 --> (pkg.C).f
        pkg.main2 --> (pkg.D).f
        pkg.main2 --> (pkg.C).f
        pkg.main2 --> (pkg.D).f
        pkg.main --> (pkg.C).f
        pkg.main --> (pkg.D).f
        pkg.main --> pkg.main2
        pkg.main --> (pkg.C).f
        pkg.main --> (pkg.D).f
        pkg.main --> (pkg.C).f
        pkg.main --> (pkg.D).f
        pkg.main --> (pkg.C).f
        pkg.main --> (pkg.D).f
        pkg.main2 --> (pkg.C).f
        pkg.main2 --> (pkg.D).f
        pkg.main2 --> (pkg.C).f
        pkg.main2 --> (pkg.D).f
        pkg.main --> pkg.main2
        
    main_test.go:77: callgraph("pta", true): missing edge: <root> --> pkg.test.main
    main_test.go:77: callgraph("pta", true): missing edge: pkg.test.main --> testing.MainStart
    main_test.go:77: callgraph("pta", true): missing edge: testing.runExample --> pkg.Example
    main_test.go:77: callgraph("pta", true): missing edge: pkg.Example --> (pkg.C).f
    main_test.go:82: got:
         pkg.main2 --> (pkg.D).f
        pkg.main --> pkg.main2
        pkg.main --> (pkg.C).f
        <root> --> pkg.init
        <root> --> pkg.main
        <root> --> pkg.init
        pkg.main2 --> (pkg.D).f
        pkg.main --> pkg.main2
        pkg.main --> (pkg.C).f
        <root> --> pkg.main
        
FAIL
FAIL	golang.org/x/tools/cmd/callgraph	4.613s
@gopherbot gopherbot added this to the Unreleased milestone Dec 12, 2018
@andybons andybons added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Dec 12, 2018
@gopherbot
Copy link

Change https://golang.org/cl/153865 mentions this issue: [release-branch.go1.11] skip failing TestCallgraph

gopherbot pushed a commit to golang/tools that referenced this issue Dec 12, 2018
@andybons
[release-branch.go1.11] skip failing TestCallgraph
37bde98 
Update golang/go#29201

Change-Id: I248aae01ecd5066bd318ef628d69a1a07725fdb6
Reviewed-on: https://go-review.googlesource.com/c/153865
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
@matloob
Copy link
Contributor

matloob commented Dec 12, 2018

go/packages was incomplete at the time the release was cut, and has been fixed/stabilized since. Because go/packages was incomplete, I think it's okay to skip this test. If this turns out to be a bigger problem, we might want to revert tools on the 1.11 branch to not use go/packages.

@agnivade
Copy link
Contributor

So this seems to be directly cherry-picked to the 1.11 branch. Should we close the issue then ?

@matloob matloob closed this as completed Dec 13, 2018
@matloob
Copy link
Contributor

matloob commented Dec 13, 2018

Yep, I forgot to close it earlier. Thanks for pointing this out!

@golang golang locked and limited conversation to collaborators Dec 13, 2019
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @agnivade @gopherbot @matloob