Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: incorrect constant value for PROCESS_ALL_ACCESS #29176

Open
Rojuinex opened this issue Dec 11, 2018 · 1 comment
Open

runtime: incorrect constant value for PROCESS_ALL_ACCESS #29176

Rojuinex opened this issue Dec 11, 2018 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@Rojuinex
Copy link

go/src/runtime/syscall_windows_test.go

Line 815 in 01e072d

_PROCESS_ALL_ACCESS = syscall.STANDARD_RIGHTS_REQUIRED | syscall.SYNCHRONIZE | 0xfff

From winnt.h we can see that if we are running on a version of Windows greater than Vista, 0xFFFF should be or-ed with the STANDARD_RIGHTS_REQUIRED and SYNCHRONIZE flags.

winnt.h#L11279

#if (NTDDI_VERSION >= NTDDI_VISTA)
#define PROCESS_ALL_ACCESS        (STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | \
                                   0xFFFF)
#else
#define PROCESS_ALL_ACCESS        (STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | \
                                   0xFFF)
#endif
@laches1sm laches1sm mentioned this issue Dec 11, 2018
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/153717 mentions this issue: runtime: PROCESS_ALL_ACCESS didn't check for 0XFFFF

@ALTree ALTree changed the title Incorrect constant value runtime: incorrect constant value forPROCESS_ALL_ACCESS Dec 12, 2018
@ALTree ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 12, 2018
@ALTree ALTree changed the title runtime: incorrect constant value forPROCESS_ALL_ACCESS runtime: incorrect constant value for PROCESS_ALL_ACCESS Dec 12, 2018
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
@prattmic prattmic added this to the Backlog milestone Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Compiler / Runtime
Status: Todo
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

runtime: PROCESS_ALL_ACCESS didn't check for 0XFFFF laches1sm/go
4 participants
@prattmic @Rojuinex @ALTree @gopherbot