Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: parameter snippets don't handle multiples with the same type #29143

Closed
stamblerre opened this issue Dec 7, 2018 · 1 comment
Closed

x/tools/internal/lsp: parameter snippets don't handle multiples with the same type #29143

stamblerre opened this issue Dec 7, 2018 · 1 comment
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

When converting from an item's completion label to the LSP snippets that get used in the insert text field, we don't handle multiple parameters with the same type. For example foo(a, b int) should generate foo(${1: a int}, ${2: b int}), but currently it generates foo(${1: a}, ${2: b int}).
@gopherbot gopherbot added this to the Unreleased milestone Dec 7, 2018
@stamblerre stamblerre self-assigned this Dec 7, 2018
@stamblerre stamblerre added the Suggested Issues that may be good for new contributors looking for work to do. label Dec 19, 2018
@stamblerre stamblerre removed their assignment Dec 19, 2018
@stamblerre
Copy link
Contributor Author

This actually was only true of builtin functions copy and complex. Fixed with https://go-review.googlesource.com/c/tools/+/158020.

@golang golang locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot